From: SourceForge.net <no...@so...> - 2008-02-26 18:46:14
|
Patches item #1902418, was opened at 2008-02-26 13:46 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=315494&aid=1902418&group_id=15494 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Andrew Mickish (mickish) Assigned to: Nobody/Anonymous (nobody) Summary: LogAxis.refreshTicksVertical() only makes MINOR ticks Initial Comment: There is a typo in LogAxis.refreshTicksVertical(). It should create MAJOR tick marks, then MINOR tick marks. The first occurrence of "MINOR" in the method should be changed to "MAJOR", to read like this: ... while (current <= end) { double v = calculateValue(current); if (range.contains(v)) { ticks.add(new NumberTick(TickType.MAJOR, v, createTickLabel(v), textAnchor, TextAnchor.CENTER, 0.0)); } // add minor ticks (for gridlines) double next = Math.pow(this.base, current + this.tickUnit.getSize()); for (int i = 1; i < this.minorTickCount; i++) { double minorV = v + i * ((next - v) / this.minorTickCount); if (range.contains(minorV)) { ticks.add(new NumberTick(TickType.MINOR, minorV, "", textAnchor, TextAnchor.CENTER, 0.0)); } } current = current + this.tickUnit.getSize(); } ... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=315494&aid=1902418&group_id=15494 |
From: SourceForge.net <no...@so...> - 2008-03-19 21:36:38
|
Patches item #1902418, was opened at 2008-02-26 18:46 Message generated for change (Settings changed) made by mungady You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=315494&aid=1902418&group_id=15494 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Andrew Mickish (mickish) >Assigned to: David Gilbert (mungady) Summary: LogAxis.refreshTicksVertical() only makes MINOR ticks Initial Comment: There is a typo in LogAxis.refreshTicksVertical(). It should create MAJOR tick marks, then MINOR tick marks. The first occurrence of "MINOR" in the method should be changed to "MAJOR", to read like this: ... while (current <= end) { double v = calculateValue(current); if (range.contains(v)) { ticks.add(new NumberTick(TickType.MAJOR, v, createTickLabel(v), textAnchor, TextAnchor.CENTER, 0.0)); } // add minor ticks (for gridlines) double next = Math.pow(this.base, current + this.tickUnit.getSize()); for (int i = 1; i < this.minorTickCount; i++) { double minorV = v + i * ((next - v) / this.minorTickCount); if (range.contains(minorV)) { ticks.add(new NumberTick(TickType.MINOR, minorV, "", textAnchor, TextAnchor.CENTER, 0.0)); } } current = current + this.tickUnit.getSize(); } ... ---------------------------------------------------------------------- >Comment By: David Gilbert (mungady) Date: 2008-03-19 21:36 Message: Logged In: YES user_id=112975 Originator: NO Thanks for spotting that. The patch is committed to Subversion for inclusion in the upcoming 1.0.10 release. Regards, Dave Gilbert JFreeChart Project Leader ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=315494&aid=1902418&group_id=15494 |