From: Peter Becker <pbecker@ds...> - 2003-03-24 07:55:55
I just managed to compile JFreeChart from CVS and run the demo app from
it, but Eclipse complains about 64 issues, most of them just being
unused imports, some are non-static calls to statics and three are
pointless assigments of the type "this.member = member", where I suspect
parameters have been deleted. Unfortunately I couldn't find any way to
export this list, but I can create a patch if you want. Here are the
three assignments without effect (refering to the CVS version about
30min old when sending this email):
- line 106 in
- line 194 in com.keypoint.PngEncoder.pngEncode(boolean)
- line 61 in com.jrefinery.ui.WizardPanel.WizardPanel(LayoutManager)
None of them does look nasty, just superflous code -- you still might
want to check on this.
A typical example of the non-static calls is
com.jrefinery.chart.demo.jdbc.swing.DbConnection.java in line 342 where
the three "this." shouldn't be there in the call to JOptionPane.
Actually line 217 looks a bit nasty: a static gets assigned with a
parameter from a constructor call. I suspect the connectTitle shouldn't
be static at all and the connectOptionNames should be final and renamed
to be CONNECT_OPTION_NAMES. Although I am just guessing from a very
quick code review. BTW: the default value of the username member is
probably unused, too.
Get latest updates about Open Source Projects, Conferences and News.