jfreechart-developers — A discussion list for JFreeChart developers

[jfreechart-dev] [ jfreechart-Bugs-3570259 ] Range.combine method with empty datasets

[SourceForge.net <no...@so...>]

Bugs item #3570259, was opened at 2012-09-20 15:48
Message generated for change (Settings changed) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
>Resolution: Duplicate
Priority: 5
Private: No
Submitted By: Matthew Lohbihler (mlohbihler)
>Assigned to: David Gilbert (mungady)
Summary: Range.combine method with empty datasets

Initial Comment:
When one or more datasets are empty within a plot, the Range.combine method returns incorrect results. The range for an empty dataset will have lower and upper values of NaN, signifying that the range is undetermined. When combining with a range that *is* determined, the NaN values prevail, which is incorrect. NaN values should be explicitly detected and discarded. Currently, determination relies on the Math.min and max methods. When run as so:

System.out.println(Math.min(Double.NaN, 0));
System.out.println(Math.min(0, Double.NaN));
System.out.println(Math.max(Double.NaN, 0));
System.out.println(Math.max(0, Double.NaN));

... the result is always NaN.

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-23 12:16

Message:
Closing as this issue is already fixed for the upcoming 1.0.15 release.

----------------------------------------------------------------------

Comment By: Matthew Lohbihler (mlohbihler)
Date: 2012-09-21 06:53

Message:
Hi Martin,

Yes, this looks like the same issue. Sorry for the dup. When r2461 and
r2462 are both used the issue should be fixed (although i have not yet
tested).

The problem occurs when one or more datasets are empty within a plot. In my
case the context is Mango M2M, SCADA software. Charts are all time series.
If a given data stream has no values for the chosen time period, the range
combine method prevents all data streams - if they have values or not -
from rendering.

----------------------------------------------------------------------

Comment By: Martin Höller (matinh)
Date: 2012-09-20 23:29

Message:
This problem has arose before. See bug #3445507 for more details and SVN
r2461 for changes.
The problematic code should probably use the new method
Range.combineIgnoringNaN() instead of Range.combine().

Could you please tell us, where/when exactly the problem triggers?
Especially what kind of chart?

- martin

----------------------------------------------------------------------

Comment By: Matthew Lohbihler (mlohbihler)
Date: 2012-09-20 15:59

Message:
The following version of the method works for me:

    public static Range combine(Range range1, Range range2) {
        if (range1 == null) {
            return range2;
        }
        else {
            if (range2 == null) {
                return range1;
            }
            else {
                double l;
                if (Double.isNaN(range1.getLowerBound()))
                    l = range2.getLowerBound();
                else if (Double.isNaN(range2.getLowerBound()))
                    l = range1.getLowerBound();
                else
                    l = Math.min(range1.getLowerBound(),
range2.getLowerBound());

                double u;
                if (Double.isNaN(range1.getUpperBound()))
                    u = range2.getUpperBound();
                else if (Double.isNaN(range2.getUpperBound()))
                    u = range1.getUpperBound();
                else
                    u = Math.max(range1.getUpperBound(),
range2.getUpperBound());

                return new Range(l, u);
            }
        }
    }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3458922 ] PeriodLabelAxisInfo createInstance() Method does not work

[SourceForge.net <no...@so...>]

Bugs item #3458922, was opened at 2011-12-13 00:22
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3458922&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
>Status: Closed
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: szediwmi (szediwmi)
Assigned to: David Gilbert (mungady)
Summary: PeriodLabelAxisInfo createInstance() Method does not work

Initial Comment:
The method createInstance() of the PeriodLabelAxisInfo class does not work since 1.0.14. The attached patch may help.

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-23 12:14

Message:
Closing this, I reviewed it again and I still don't see anything to fix.

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2011-12-17 00:54

Message:
I'm not sure what you mean by 'does not work'.  Could you provide an
example of some code that fails?  I added a small unit test:

    /**
     * A test for the createInstance() method.
     */
    public void testCreateInstance() {
        PeriodAxisLabelInfo info = new PeriodAxisLabelInfo(Day.class, 
                new SimpleDateFormat("d"));
        Day d = (Day) info.createInstance(new Date(0L), 
                TimeZone.getTimeZone("GMT"), Locale.UK);
        assertEquals(new Day(1, 1, 1970), d);
    }

...and that works as expected.  Looking at the PeriodAxisLabelInfo class, I
think it would be possible to specify a 'Class' that is not a subclass of
RegularTimePeriod and that would generate an exception in this method, but
in that case nothing is going to work anyway.

If you can clarify the bug, I'll take another look.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3458922&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3570259 ] Range.combine method with empty datasets

[SourceForge.net <no...@so...>]

Bugs item #3570259, was opened at 2012-09-20 15:48
Message generated for change (Comment added) made by mlohbihler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthew Lohbihler (mlohbihler)
Assigned to: Nobody/Anonymous (nobody)
Summary: Range.combine method with empty datasets

Initial Comment:
When one or more datasets are empty within a plot, the Range.combine method returns incorrect results. The range for an empty dataset will have lower and upper values of NaN, signifying that the range is undetermined. When combining with a range that *is* determined, the NaN values prevail, which is incorrect. NaN values should be explicitly detected and discarded. Currently, determination relies on the Math.min and max methods. When run as so:

System.out.println(Math.min(Double.NaN, 0));
System.out.println(Math.min(0, Double.NaN));
System.out.println(Math.max(Double.NaN, 0));
System.out.println(Math.max(0, Double.NaN));

... the result is always NaN.

----------------------------------------------------------------------

>Comment By: Matthew Lohbihler (mlohbihler)
Date: 2012-09-21 06:53

Message:
Hi Martin,

Yes, this looks like the same issue. Sorry for the dup. When r2461 and
r2462 are both used the issue should be fixed (although i have not yet
tested).

The problem occurs when one or more datasets are empty within a plot. In my
case the context is Mango M2M, SCADA software. Charts are all time series.
If a given data stream has no values for the chosen time period, the range
combine method prevents all data streams - if they have values or not -
from rendering.

----------------------------------------------------------------------

Comment By: Martin Höller (matinh)
Date: 2012-09-20 23:29

Message:
This problem has arose before. See bug #3445507 for more details and SVN
r2461 for changes.
The problematic code should probably use the new method
Range.combineIgnoringNaN() instead of Range.combine().

Could you please tell us, where/when exactly the problem triggers?
Especially what kind of chart?

- martin

----------------------------------------------------------------------

Comment By: Matthew Lohbihler (mlohbihler)
Date: 2012-09-20 15:59

Message:
The following version of the method works for me:

    public static Range combine(Range range1, Range range2) {
        if (range1 == null) {
            return range2;
        }
        else {
            if (range2 == null) {
                return range1;
            }
            else {
                double l;
                if (Double.isNaN(range1.getLowerBound()))
                    l = range2.getLowerBound();
                else if (Double.isNaN(range2.getLowerBound()))
                    l = range1.getLowerBound();
                else
                    l = Math.min(range1.getLowerBound(),
range2.getLowerBound());

                double u;
                if (Double.isNaN(range1.getUpperBound()))
                    u = range2.getUpperBound();
                else if (Double.isNaN(range2.getUpperBound()))
                    u = range1.getUpperBound();
                else
                    u = Math.max(range1.getUpperBound(),
range2.getUpperBound());

                return new Range(l, u);
            }
        }
    }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3570259 ] Range.combine method with empty datasets

[SourceForge.net <no...@so...>]

Bugs item #3570259, was opened at 2012-09-20 15:48
Message generated for change (Comment added) made by matinh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthew Lohbihler (mlohbihler)
Assigned to: Nobody/Anonymous (nobody)
Summary: Range.combine method with empty datasets

Initial Comment:
When one or more datasets are empty within a plot, the Range.combine method returns incorrect results. The range for an empty dataset will have lower and upper values of NaN, signifying that the range is undetermined. When combining with a range that *is* determined, the NaN values prevail, which is incorrect. NaN values should be explicitly detected and discarded. Currently, determination relies on the Math.min and max methods. When run as so:

System.out.println(Math.min(Double.NaN, 0));
System.out.println(Math.min(0, Double.NaN));
System.out.println(Math.max(Double.NaN, 0));
System.out.println(Math.max(0, Double.NaN));

... the result is always NaN.

----------------------------------------------------------------------

Comment By: Martin Höller (matinh)
Date: 2012-09-20 23:29

Message:
This problem has arose before. See bug #3445507 for more details and SVN
r2461 for changes.
The problematic code should probably use the new method
Range.combineIgnoringNaN() instead of Range.combine().

Could you please tell us, where/when exactly the problem triggers?
Especially what kind of chart?

- martin

----------------------------------------------------------------------

Comment By: Matthew Lohbihler (mlohbihler)
Date: 2012-09-20 15:59

Message:
The following version of the method works for me:

    public static Range combine(Range range1, Range range2) {
        if (range1 == null) {
            return range2;
        }
        else {
            if (range2 == null) {
                return range1;
            }
            else {
                double l;
                if (Double.isNaN(range1.getLowerBound()))
                    l = range2.getLowerBound();
                else if (Double.isNaN(range2.getLowerBound()))
                    l = range1.getLowerBound();
                else
                    l = Math.min(range1.getLowerBound(),
range2.getLowerBound());

                double u;
                if (Double.isNaN(range1.getUpperBound()))
                    u = range2.getUpperBound();
                else if (Double.isNaN(range2.getUpperBound()))
                    u = range1.getUpperBound();
                else
                    u = Math.max(range1.getUpperBound(),
range2.getUpperBound());

                return new Range(l, u);
            }
        }
    }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3570259 ] Range.combine method with empty datasets

[SourceForge.net <no...@so...>]

Bugs item #3570259, was opened at 2012-09-20 15:48
Message generated for change (Comment added) made by mlohbihler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthew Lohbihler (mlohbihler)
Assigned to: Nobody/Anonymous (nobody)
Summary: Range.combine method with empty datasets

Initial Comment:
When one or more datasets are empty within a plot, the Range.combine method returns incorrect results. The range for an empty dataset will have lower and upper values of NaN, signifying that the range is undetermined. When combining with a range that *is* determined, the NaN values prevail, which is incorrect. NaN values should be explicitly detected and discarded. Currently, determination relies on the Math.min and max methods. When run as so:

System.out.println(Math.min(Double.NaN, 0));
System.out.println(Math.min(0, Double.NaN));
System.out.println(Math.max(Double.NaN, 0));
System.out.println(Math.max(0, Double.NaN));

... the result is always NaN.

----------------------------------------------------------------------

>Comment By: Matthew Lohbihler (mlohbihler)
Date: 2012-09-20 15:59

Message:
The following version of the method works for me:

    public static Range combine(Range range1, Range range2) {
        if (range1 == null) {
            return range2;
        }
        else {
            if (range2 == null) {
                return range1;
            }
            else {
                double l;
                if (Double.isNaN(range1.getLowerBound()))
                    l = range2.getLowerBound();
                else if (Double.isNaN(range2.getLowerBound()))
                    l = range1.getLowerBound();
                else
                    l = Math.min(range1.getLowerBound(),
range2.getLowerBound());

                double u;
                if (Double.isNaN(range1.getUpperBound()))
                    u = range2.getUpperBound();
                else if (Double.isNaN(range2.getUpperBound()))
                    u = range1.getUpperBound();
                else
                    u = Math.max(range1.getUpperBound(),
range2.getUpperBound());

                return new Range(l, u);
            }
        }
    }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3570259 ] Range.combine method with empty datasets

[SourceForge.net <no...@so...>]

Bugs item #3570259, was opened at 2012-09-20 15:48
Message generated for change (Tracker Item Submitted) made by mlohbihler
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Matthew Lohbihler (mlohbihler)
Assigned to: Nobody/Anonymous (nobody)
Summary: Range.combine method with empty datasets

Initial Comment:
When one or more datasets are empty within a plot, the Range.combine method returns incorrect results. The range for an empty dataset will have lower and upper values of NaN, signifying that the range is undetermined. When combining with a range that *is* determined, the NaN values prevail, which is incorrect. NaN values should be explicitly detected and discarded. Currently, determination relies on the Math.min and max methods. When run as so:

System.out.println(Math.min(Double.NaN, 0));
System.out.println(Math.min(0, Double.NaN));
System.out.println(Math.max(Double.NaN, 0));
System.out.println(Math.max(0, Double.NaN));

... the result is always NaN.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3570259&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3482106 ] ChartComposite Axis & legend label not visible (1.0.14)

[SourceForge.net <no...@so...>]

Bugs item #3482106, was opened at 2012-01-31 00:49
Message generated for change (Settings changed) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3482106&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: plhr (plhr)
>Assigned to: David Gilbert (mungady)
Summary: ChartComposite Axis & legend label not visible (1.0.14)

Initial Comment:
With the new version of JfreeChart (1.0.14) it is not possible to see the axis labels for ChartComposite
LegendItems labels are not visible too, but the coulour line and shapes are visible.
With the same code the ChartComposite works as expected with JfreeChart 1.0.13, so I think the problem could be linked to the new version of Jfree and swt jar.
Other informations :
- OS : windows 7 x86_64
- SWT : org.eclipse.swt.win32.win32.x86_3.7.0
- Eclipse Indigo (3.7)

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2012-09-18 13:49

Message:
There is a fix for this within patch 3506228.  The fix will be included in
the upcoming 1.0.15 release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3482106&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3482106 ] ChartComposite Axis & legend label not visible (1.0.14)

[SourceForge.net <no...@so...>]

Bugs item #3482106, was opened at 2012-01-31 00:49
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3482106&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: plhr (plhr)
Assigned to: Nobody/Anonymous (nobody)
Summary: ChartComposite Axis & legend label not visible (1.0.14)

Initial Comment:
With the new version of JfreeChart (1.0.14) it is not possible to see the axis labels for ChartComposite
LegendItems labels are not visible too, but the coulour line and shapes are visible.
With the same code the ChartComposite works as expected with JfreeChart 1.0.13, so I think the problem could be linked to the new version of Jfree and swt jar.
Other informations :
- OS : windows 7 x86_64
- SWT : org.eclipse.swt.win32.win32.x86_3.7.0
- Eclipse Indigo (3.7)

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-18 13:49

Message:
There is a fix for this within patch 3506228.  The fix will be included in
the upcoming 1.0.15 release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3482106&group_id=15494

[jfreechart-dev] [ jfreechart-Patches-3358964 ] Mouse Zoom only works from top left going down and right

[SourceForge.net <no...@so...>]

Patches item #3358964, was opened at 2011-07-08 13:23
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=315494&aid=3358964&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Fodge (felldiddy)
>Assigned to: David Gilbert (mungady)
Summary: Mouse Zoom only works from top left going down and right

Initial Comment:
When using a ChartPanel with mouse zooming enabled, the zoom box is only drawn and zooming only occurs when the mouse is dragged from top left to bottom right.  The rectangle coordinates should be normalized and then sent to zooming/zoom-box drawing.  Otherwise, it is practically possible to zoom in on, say, the very left edge or the very top edge.

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-18 13:32

Message:
That's by design...zooming dragging up and left resets the zoom.  I agree
with you that it is a bit hard to zoom on the top left edge though, and the
proposed path looks like a reasonable solution.  Moving to the patch
tracker.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2011-12-03 07:19

Message:
Index: ChartPanel.java
===================================================================
--- ChartPanel.java	(revision 2440)
+++ ChartPanel.java	(working copy)
@@ -539,6 +539,13 @@
      */
     private List overlays;
 
+    
+    /** BUGFIX ID: 3358964
+    "Mouse Zoom only works from top left going down and right" -
+    Flag to change Zooming Behavior
+    */
+    private boolean zoomAllDirections = false;
+    
     /**
      * Constructs a panel that displays the specified chart.
      *
@@ -759,7 +766,27 @@
         return this.chart;
     }
 
+    
+     /**
+     * Returns if ZoomAllDirection is set.
+     *
+     * @return Boolean
+     */
+    public boolean isZoomAllDirections() {
+      return zoomAllDirections;
+    }
+
     /**
+     *  Enable / Disable ZoomAllDirection.
+     *
+     * @param Enable / Disable Zooming All Direction
+     */
+    public void setZoomAllDirections(boolean zoomAllDirections) {
+       this.zoomAllDirections = zoomAllDirections;
+    }
+
+	
+	/**
      * Sets the chart that is displayed in the panel.
      *
      * @param chart  the chart (<code>null</code> permitted).
@@ -2006,6 +2033,10 @@
                     scaledDataArea.getWidth(), ymax -
this.zoomPoint.getY());
         }
 
+        if (zoomAllDirections) {
+    		correctZoomRectangle();
+    	}
+        
         // Draw the new zoom rectangle...
         if (this.useBuffer) {
             repaint();
@@ -2018,6 +2049,28 @@
         g2.dispose();
 
     }
+    
+ 
+    /**
+     * Can be called to correct the coordinates, width and height of the
zoomRectangle 
+     * (i.e. when dragging the mouse from bottom right to top left)
+     */
+	private void correctZoomRectangle() {
+		
+       double x = zoomRectangle.getX();
+       double y = zoomRectangle.getY();
+       double w = zoomRectangle.getWidth();
+       double h = zoomRectangle.getHeight();
+		
+       if (w < 0 && h < 0) {
+            zoomRectangle.setRect(x + w, y + h, -w, -h);				
+           } else if (w < 0) {
+              zoomRectangle.setRect(x + w, y, -w, h);				
+            } else if (h < 0){
+                 zoomRectangle.setRect(x, y + h, w, -h);				
+       }
+     }
+    
 
     /**
      * Handles a 'mouse released' event.  On Windows, we need to check if
this
@@ -2052,9 +2105,9 @@
             boolean zoomTrigger2 = vZoom && Math.abs(e.getY()
                 - this.zoomPoint.getY()) >= this.zoomTriggerDistance;
             if (zoomTrigger1 || zoomTrigger2) {
-                if ((hZoom && (e.getX() < this.zoomPoint.getX()))
-                    || (vZoom && (e.getY() < this.zoomPoint.getY()))) {
-                    restoreAutoBounds();
+                if (!zoomAllDirections && ((hZoom && (e.getX() <
this.zoomPoint.getX()))
+                    || (vZoom && (e.getY() < this.zoomPoint.getY())))) {
+                    	restoreAutoBounds(); 
                 }
                 else {
                     double x, y, w, h;
@@ -2067,27 +2120,28 @@
                     // will be true, so we can just test for either being
false;
                     // otherwise both are true
                     if (!vZoom) {
-                        x = this.zoomPoint.getX();
+                        x = this.zoomRectangle.getX();
                         y = screenDataArea.getMinY();
                         w = Math.min(this.zoomRectangle.getWidth(),
-                                maxX - this.zoomPoint.getX());
+                                maxX - this.zoomRectangle.getX());
                         h = screenDataArea.getHeight();
                     }
                     else if (!hZoom) {
                         x = screenDataArea.getMinX();
-                        y = this.zoomPoint.getY();
+                        y = this.zoomRectangle.getY();
                         w = screenDataArea.getWidth();
                         h = Math.min(this.zoomRectangle.getHeight(),
-                                maxY - this.zoomPoint.getY());
+                                maxY - this.zoomRectangle.getY());
                     }
                     else {
-                        x = this.zoomPoint.getX();
-                        y = this.zoomPoint.getY();
+                        x = this.zoomRectangle.getX();
+                        y = this.zoomRectangle.getY();
                         w = Math.min(this.zoomRectangle.getWidth(),
-                                maxX - this.zoomPoint.getX());
+                                maxX - this.zoomRectangle.getX());
                         h = Math.min(this.zoomRectangle.getHeight(),
-                                maxY - this.zoomPoint.getY());
+                                maxY - this.zoomRectangle.getY());
                     }
+                    
                     Rectangle2D zoomArea = new Rectangle2D.Double(x, y, w,
h);
                     zoom(zoomArea);
                 }
@@ -2095,29 +2149,32 @@
                 this.zoomRectangle = null;
             }
             else {
-                // erase the zoom rectangle
+            	
+                if (zoomAllDirections) {
+                   correctZoomRectangle();
+                }
+
+                 // erase the zoom rectangle
                 Graphics2D g2 = (Graphics2D) getGraphics();
                 if (this.useBuffer) {
-                    repaint();
+                 repaint();
                 }
                 else {
-                    drawZoomRectangle(g2, true);
+                  drawZoomRectangle(g2, true);
                 }
                 g2.dispose();
                 this.zoomPoint = null;
                 this.zoomRectangle = null;
-            }
-
+             }
         }
 
         else if (e.isPopupTrigger()) {
-            if (this.popup != null) {
-                displayPopupMenu(e.getX(), e.getY());
-            }
+              if (this.popup != null) {
+              displayPopupMenu(e.getX(), e.getY());
+             }
         }
+   }
 
-    }
-
     /**
      * Receives notification of mouse clicks on the panel. These are
      * translated and passed on to any registered {@link
ChartMouseListener}s.


----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2011-12-03 07:18

Message:
Hi guys,
refering to Martin Höllers hints, i startet to create a Patch for the
ChartPanel.java

Please have a closer look to it. 
Furthermore I hope i keep all coding conventions.

Regards,
Robert

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=315494&aid=3358964&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3445507 ] Regression in handling missing values in 1.0.14

[SourceForge.net <no...@so...>]

Bugs item #3445507, was opened at 2011-11-29 12:53
Message generated for change (Settings changed) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3445507&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
>Status: Closed
>Resolution: Fixed
Priority: 7
Private: No
Submitted By: Jon Doh (bigbang)
Assigned to: David Gilbert (mungady)
Summary: Regression in handling missing values in 1.0.14

Initial Comment:
I don't know if this is deliberate, but 1.0.13 and 1.0.14 handle missing values differently. If one time series has all values missing, nothing is drawn on the chart, not even other time series.

----------------------------------------------------------------------

Comment By: Martin Höller (matinh)
Date: 2012-04-03 04:24

Message:
There seems to be more bugs related to this.
See the user forum for another bug report and a potential fix in the XYPlot
class:
http://www.jfree.org/phpBB2/viewtopic.php?f=3&t=110165&p=168394

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2012-01-08 12:17

Message:
Fixed for the upcoming 1.0.15 release.

----------------------------------------------------------------------

Comment By: Martin Höller (matinh)
Date: 2011-12-16 15:33

Message:
The problem seems to be in the new TimeSeriesCollection.getRangeBounds()
method (since 1.0.14). This method uses result = Range.combine(result, r);
where r is Range[NaN,NaN], The Range.combine() method doesn't deal with
this situation and returns an invalid range of Range[NaN,NaN], no matter
what the other range is.

So the solution would be either fix Range.combine() in a way that it can
handle NaN values, or make sure it is not called with NaN values from
TimeSeriesCollection.getRangeBounds().

David, you assigned this issue to yourself. If you find time to fix it,
just do so. If I'll come up with a fix, I'll let you know.


----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2011-11-29 20:49

Message:
Thanks for the report - it sounds like a bug to me.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3445507&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3514487 ] AWT/SWT constants conversion in SWTGraphics2D class

[SourceForge.net <no...@so...>]

Bugs item #3514487, was opened at 2012-04-03 03:10
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3514487&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: olivier (olivierpod)
>Assigned to: David Gilbert (mungady)
Summary: AWT/SWT constants conversion in SWTGraphics2D class

Initial Comment:
Sample code from org.jfree.experimental.SWTGraphics2D (v1.0.13 but this code part is identical in v1.0.14):
-----------------------------------------------------------
    public Stroke getStroke() {
        return new BasicStroke(this.gc.getLineWidth(), this.gc.getLineCap(),
                this.gc.getLineJoin());
    }

    public void setStroke(Stroke stroke) {
        if (stroke instanceof BasicStroke) {
            BasicStroke bs = (BasicStroke) stroke;
            // linewidth
            this.gc.setLineWidth((int) bs.getLineWidth());

            // line join
            switch (bs.getLineJoin()) {
                case BasicStroke.JOIN_BEVEL :
                    this.gc.setLineJoin(SWT.JOIN_BEVEL);
                    break;
                case BasicStroke.JOIN_MITER :
                    this.gc.setLineJoin(SWT.JOIN_MITER);
                    break;
                case BasicStroke.JOIN_ROUND :
                    this.gc.setLineJoin(SWT.JOIN_ROUND);
                    break;
            }

            // line cap
            switch (bs.getEndCap()) {
                case BasicStroke.CAP_BUTT :
                    this.gc.setLineCap(SWT.CAP_FLAT);
                    break;
                case BasicStroke.CAP_ROUND :
                    this.gc.setLineCap(SWT.CAP_ROUND);
                    break;
                case BasicStroke.CAP_SQUARE :
                    this.gc.setLineCap(SWT.CAP_SQUARE);
                    break;
            }

            // set the line style to solid by default
            this.gc.setLineStyle(SWT.LINE_SOLID);

            // apply dash style if any
            float[] dashes = bs.getDashArray();
            if (dashes != null) {
                int[] swtDashes = new int[dashes.length];
                for (int i = 0; i < swtDashes.length; i++) {
                    swtDashes[i] = (int) dashes[i];
                }
                this.gc.setLineDash(swtDashes);
            }
        }
        else {
            throw new RuntimeException(
                    "Can only handle 'Basic Stroke' at present.");
        }
    }
-----------------------------------------------------------

PROBLEM: 
In the setStroke method, BasicStroke line join and line cap constant values are converted to SWT constant values before being stored into the SWT GC, but
in the getStroke method, the GC line cap and line join values are passed to the AWT BasicStroke class constructor without any conversion.

It causes an "illegal end cap value" or an "illegal line join value" in the BasicStroke class initialization, depending on the initialization context.


----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-18 13:25

Message:
This has been fixed for the upcoming 1.0.15 release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3514487&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3508799 ] getSeriesKey() in LegendItemEntity for PolarPlot always null

[SourceForge.net <no...@so...>]

Bugs item #3508799, was opened at 2012-03-19 09:04
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3508799&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: General
>Group: 1.0.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: AE ()
>Assigned to: David Gilbert (mungady)
Summary: getSeriesKey() in LegendItemEntity for PolarPlot always null

Initial Comment:
LegendItemEntity.getSeriesKey() works great for capturing mouse click events in the legend so I can highlight specific series with a chart initialized with ChartFactory.createXYLineChart(), but always returns null when initialized with ChartFactory.createPolarChart(). 

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-18 12:53

Message:
This has been fixed for the upcoming 1.0.15 release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3508799&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3555275 ] Problem with fixedDimension in ValueAxis.reserveSpace

[SourceForge.net <no...@so...>]

Bugs item #3555275, was opened at 2012-08-08 00:19
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3555275&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Martin Höller (matinh)
Assigned to: David Gilbert (mungady)
Summary: Problem with fixedDimension in ValueAxis.reserveSpace

Initial Comment:
In the forum a bug (along with a fix) was reported regarding fixedDimension and reserving space:
http://www.jfree.org/forum/viewtopic.php?f=3&t=115547

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-03 22:33

Message:
I committed the fix for the upcoming 1.0.15 release.

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2012-09-03 12:42

Message:
I posted a possible fix in the forum thread, along with a JUnit test. 
Feedback is welcome, I don't have a lot of time to test all the cases that
might be affected (that said, the existing code seems quite wrong, so I
doubt my patch will make it worse)..

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3555275&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3555275 ] Problem with fixedDimension in ValueAxis.reserveSpace

[SourceForge.net <no...@so...>]

Bugs item #3555275, was opened at 2012-08-08 00:19
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3555275&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Martin Höller (matinh)
>Assigned to: David Gilbert (mungady)
Summary: Problem with fixedDimension in ValueAxis.reserveSpace

Initial Comment:
In the forum a bug (along with a fix) was reported regarding fixedDimension and reserving space:
http://www.jfree.org/forum/viewtopic.php?f=3&t=115547

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-09-03 12:42

Message:
I posted a possible fix in the forum thread, along with a JUnit test. 
Feedback is welcome, I don't have a lot of time to test all the cases that
might be affected (that said, the existing code seems quite wrong, so I
doubt my patch will make it worse)..

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3555275&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3563218 ] hidden annotations with a SlidingGanttCategoryDataset

[SourceForge.net <no...@so...>]

Bugs item #3563218, was opened at 2012-08-30 02:36
Message generated for change (Tracker Item Submitted) made by c_inconnu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3563218&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David DIDIER (c_inconnu)
Assigned to: Nobody/Anonymous (nobody)
Summary: hidden annotations with a SlidingGanttCategoryDataset

Initial Comment:
considering a SlidingGanttCategoryDataset displaying Td tasks from a total of Tt tasks (Td < Tt)
When I add a CategoryTextAnnotation to a task T which is not displayed (T > Td)
Then I got an IllegalArgumentException

indeed in CategoryTextAnnotation.draw, there is:
        int catIndex = dataset.getColumnIndex(this.category);
which is delegated to the SlidingGanttCategoryDataset and lastCategoryIndex() returns Td so getColumnIndex returns -1:
    public int getColumnIndex(Comparable key) {
        int index = this.underlying.getColumnIndex(key);
        if (index >= this.firstCategoryIndex && index <= lastCategoryIndex()) {
            return index - this.firstCategoryIndex;
        }
        return -1;  // we didn't find the key
    }
and catIndex = -1

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3563218&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3561093 ] Time series chart rendering issue

[SourceForge.net <no...@so...>]

Bugs item #3561093, was opened at 2012-08-23 12:01
Message generated for change (Comment added) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3561093&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: David Gilbert (mungady)
Assigned to: David Gilbert (mungady)
Summary: Time series chart rendering issue

Initial Comment:
Report of a rendering anomaly via StackOverFlow.com.  See this thread in the forum:

http://www.jfree.org/forum/viewtopic.php?f=3&t=115655

----------------------------------------------------------------------

>Comment By: David Gilbert (mungady)
Date: 2012-08-23 12:55

Message:
Fixed for the upcoming 1.0.15 release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3561093&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3561093 ] Time series chart rendering issue

[SourceForge.net <no...@so...>]

Bugs item #3561093, was opened at 2012-08-23 12:01
Message generated for change (Tracker Item Submitted) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3561093&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: David Gilbert (mungady)
Assigned to: David Gilbert (mungady)
Summary: Time series chart rendering issue

Initial Comment:
Report of a rendering anomaly via StackOverFlow.com.  See this thread in the forum:

http://www.jfree.org/forum/viewtopic.php?f=3&t=115655

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3561093&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3560930 ] NPE in BlockContainer for ColumnArrangement

[SourceForge.net <no...@so...>]

Bugs item #3560930, was opened at 2012-08-23 01:32
Message generated for change (Settings changed) made by rubinovk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3560930&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Deleted
Resolution: None
Priority: 5
Private: No
Submitted By: Konstantin_R (rubinovk)
Assigned to: Nobody/Anonymous (nobody)
Summary: NPE in BlockContainer for ColumnArrangement

Initial Comment:
According to the documentation BlockContainer's method add() permits null values. However, it's method arrange() fails with NullPointerException for ColumnArrangement arrangement in this case.

Code that shows the problem:

public void testBlockContainerArrange() throws Exception {
	BlockContainer container = new BlockContainer(new ColumnArrangement());
	container.add(null); // null is permitted
	container.arrange(null, new RectangleConstraint(20, 10));
}

The exact same problem occurs for FlowArrangement and does not occur for other arrangements.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3560930&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3560930 ] NPE in BlockContainer for ColumnArrangement

[SourceForge.net <no...@so...>]

Bugs item #3560930, was opened at 2012-08-23 01:32
Message generated for change (Tracker Item Submitted) made by rubinovk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3560930&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Konstantin_R (rubinovk)
Assigned to: Nobody/Anonymous (nobody)
Summary: NPE in BlockContainer for ColumnArrangement

Initial Comment:
According to the documentation BlockContainer's method add() permits null values. However, it's method arrange() fails with NullPointerException for ColumnArrangement arrangement in this case.

Code that shows the problem:

public void testBlockContainerArrange() throws Exception {
	BlockContainer container = new BlockContainer(new ColumnArrangement());
	container.add(null); // null is permitted
	container.arrange(null, new RectangleConstraint(20, 10));
}

The exact same problem occurs for FlowArrangement and does not occur for other arrangements.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3560930&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3560927 ] NPE in BlockContainer for ColumnArrangement

[SourceForge.net <no...@so...>]

Bugs item #3560927, was opened at 2012-08-23 01:11
Message generated for change (Tracker Item Submitted) made by rubinovk
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3560927&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Konstantin_R (rubinovk)
Assigned to: Nobody/Anonymous (nobody)
Summary: NPE in BlockContainer for ColumnArrangement

Initial Comment:
According to the documentation BlockContainer's method add() permits null values. However, it's method arrange() fails with NullPointerException for ColumnArrangement arrangement in this case.

Code that shows the problem:

public void testBlockContainerArrange() throws Exception {
	BlockContainer container = new BlockContainer(new ColumnArrangement());
	container.add(null); // null is permitted
	container.arrange(null, new RectangleConstraint(20, 10));
}

The exact same problem occurs for FlowArrangement and does not occur for other arrangements.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3560927&group_id=15494

Re: [jfreechart-dev] Importing jfreechart into git (again)

[David G. <da...@jf...>]

Hi,

Time flies!  Here is the link for JFreeChart FSE on GitHub as mentioned 
below.

https://github.com/jfree/jfreechart-fse

This "future state edition" of JFreeChart is not constrained by API 
backwards compatibility, so I started making changes like:

- removing the JCommon dependency;
- removing deprecated classes/methods;
- fixing some incomplete interface definitions;
- using some Java 6 features;

...and so on.  Maven is in there too.

As I said before, I'd like to get a bit of experience with GitHub using 
this project, before committing to moving the JFreeChart 1.0.x sources 
out of SVN (SourceForge).

Best regards,
David

On 31/07/2012 18:33, David Gilbert wrote:
> Hi All,
> Thanks for your continued interest! I opened an account on GitHub to 
> experiment already, and I have created a repo for what I've called 
> JFreeChart FSE ("future state edition"). It's basically trunk or dev. 
> Let me make that public as soon as I get back to a machine I can work 
> on (travelling right now, be home soon).
>
> For jfreechart-1.0.x, it sounds like I will be able to leverage what 
> Ben has done already, but can we do a short try-out on the repo I have 
> created first, because I'm still getting used to git/GitHub so I have 
> a bit of learning/unlearning to do?
>
> You are on the right track with the current svn - only the 1.0.x 
> branch matters much.
>
> Best regards,
> David
>
> P.S. Still want to get 1.0.15 released sooner rather than later.
> -- 
> Sent from my Android phone with K-9 Mail. Please excuse my brevity.
>
> "Martin Höller" <ma...@xs...> wrote:
>
>     Hi Ben!
>
>     On Tuesday 31 July 2012 Ben Greear wrote:
>     >  I made an attempt today to pull in the public svn
>     >  repository into a git repository (using svn2git).
>     >
>     >  It seems to have gone fairly well..but a few questions:
>     >
>     >  I ended up with 3 branches:
>     >  [greearb@ben-dt jfreechart]$ git branch
>     >     jfreechart-1.0.8-security
>     >     jfreechart-1.0.x-branch
>     >  * master
>     >
>     >
>     >  It appears that the 1.0.x tree is the one under current
>     >  development.
>
>     Correct.
>
>     >  master seems to have not been touched in several years.
>
>     AFAIK, David used to port changes from the 1.0.x branch to master. Nowadays
>     nobod does this anymore. I don't know the idea behind master.
>
>     >  Most other git projects that I'm aware of typically have only a single
>     >  'master'
>     branch for their upstream repository (and have multiple trees
>     >  instead of multiple branches, so there might be another
>     >  jfreechart-1.0.8-security tree that occasionally gets bug-fixes).
>     >
>     >  This makes it easy for users to download the branch they care about
>     >  by default and not have to worry about which branch to check out.
>
>     I completely agree with you. The first time I got in touch with JFreeChart's
>     source, I also got confused by the branches.
>
>     >  So, my first instinct is to make jfreechart-1.0.x-branch the
>     >  master branch, and ignore 1.0.8-security entirely.
>
>     That's the way to go!
>
>     >  I do *NOT* want to take over management of this project, but
>     >  I will be happy to make some attempts at getting the svn trees
>     >  migrated to github if David Gilbert agrees....  Once it is on
>     >  github, David and whoever else could fork the github project
>     >  and that could
>     become the true upstream tree.
>
>     Thanks for you effort!
>
>     - martin
>     ------------------------------------------------------------------------
>
>     Live Security Virtual Conference
>     Exclusive live event will cover all the ways today's security and
>     threat landscape has changed and how IT managers can respond. Discussions
>     will include endpoint security, mobile security and the latest in malware
>     threats.http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>     ------------------------------------------------------------------------
>
>     jfreechart-developers mailing list
>     jfr...@li...
>     https://lists.sourceforge.net/lists/listinfo/jfreechart-developers
>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>
> _______________________________________________
> jfreechart-developers mailing list
> jfr...@li...
> https://lists.sourceforge.net/lists/listinfo/jfreechart-developers

[jfreechart-dev] [ jfreechart-Bugs-3555275 ] Problem with fixedDimension in ValueAxis.reserveSpace

[SourceForge.net <no...@so...>]

Bugs item #3555275, was opened at 2012-08-08 00:19
Message generated for change (Tracker Item Submitted) made by matinh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3555275&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Martin Höller (matinh)
Assigned to: Nobody/Anonymous (nobody)
Summary: Problem with fixedDimension in ValueAxis.reserveSpace

Initial Comment:
In the forum a bug (along with a fix) was reported regarding fixedDimension and reserving space:
http://www.jfree.org/forum/viewtopic.php?f=3&t=115547

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3555275&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3523195 ] Combined XY Plot Axis Display Area Problem

[SourceForge.net <no...@so...>]

Bugs item #3523195, was opened at 2012-05-03 00:42
Message generated for change (Comment added) made by jylaxx
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3523195&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Combined XY Plot Axis Display Area Problem

Initial Comment:
When I am using CombinedDomainXYPlot with a PeriodAxis, the starting and ending position of the axis seems not correct, with the starting position shifted a little bit to the left-side, and the ending position shifted to the right-side, i.e. the axis is longer than it should be, causing the ticks in between does not match exactly with the grid lines in the sub-plots.

When the same PeriodAxis is added to the sub-plots, this problem does not occur. All the demos under Combined Axis Charts in the JFreeChart 1.0.13 Demo Collection seems have these problem as well.


----------------------------------------------------------------------

Comment By: Jean-Yves LINET (jylaxx)
Date: 2012-08-04 08:42

Message:
Well I don't find how to attach a file... so here the method Draw fix :
//CombinedDomainXYPlot
public void draw(Graphics2D g2,
                     Rectangle2D area,
                     Point2D anchor,
                     PlotState parentState,
                     PlotRenderingInfo info) {

        // set up info collection...
        if (info != null) {
            info.setPlotArea(area);
        }

        // adjust the drawing area for plot insets (if any)...
        RectangleInsets insets = getInsets();
        insets.trim(area);

        setFixedRangeAxisSpaceForSubplots(null);
        AxisSpace space = calculateAxisSpace(g2, area);
        Rectangle2D dataArea = space.shrink(area, null);

		this.getAxisOffset().trim(dataArea);	// fix part #1

        // set the width and height of non-shared axis of all sub-plots
        setFixedRangeAxisSpaceForSubplots(space);

        // draw the shared axis
        ValueAxis axis = getDomainAxis();
        RectangleEdge edge = getDomainAxisEdge();
        double cursor = 0.0 ; //RectangleEdge.coordinate(dataArea, edge);
		// fix part #2
        if (edge == RectangleEdge.TOP) {
            cursor = dataArea.getMinY() -
this.getAxisOffset().calculateTopOutset(dataArea.getHeight());
        }
        else if (edge == RectangleEdge.BOTTOM) {
            cursor = dataArea.getMaxY() +
this.getAxisOffset().calculateBottomOutset(dataArea.getHeight());
        }
        else if (edge == RectangleEdge.LEFT) {
            cursor = dataArea.getMinX() -
this.getAxisOffset().calculateLeftOutset(dataArea.getWidth());
        }
        else if (edge == RectangleEdge.RIGHT) {
            cursor = dataArea.getMaxX() +
this.getAxisOffset().calculateRightOutset(dataArea.getWidth());
        }
		// fix end
		AxisState axisState = axis.draw(g2, cursor, area, dataArea, edge, info);
        if (parentState == null) {
            parentState = new PlotState();
        }
        parentState.getSharedAxisStates().put(axis, axisState);

        // draw all the subplots
        for (int i = 0; i < this.subplots.size(); i++) {
            XYPlot plot = (XYPlot) this.subplots.get(i);
            PlotRenderingInfo subplotInfo = null;
            if (info != null) {
                subplotInfo = new PlotRenderingInfo(info.getOwner());
                info.addSubplotInfo(subplotInfo);
            }
            plot.draw(g2, this.subplotAreas[i], anchor, parentState,
                    subplotInfo);
        }

        if (info != null) {
            info.setDataArea(dataArea);
        }

    }

----------------------------------------------------------------------

Comment By: Jean-Yves LINET (jylaxx)
Date: 2012-08-04 08:32

Message:
A complete fix has to take care of the axisOffset.
I suggest a fixed code in attached file.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-05-15 02:52

Message:
Found a temporary workaround for the issue.

By overriding the draw() method and adjust dataArea before passing it to
super.draw():

dataArea.setRect(dataArea.getX()+4, dataArea.getY(), dataArea.getWidth()-8,
dataArea.getHeight());

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3523195&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3523195 ] Combined XY Plot Axis Display Area Problem

[SourceForge.net <no...@so...>]

Bugs item #3523195, was opened at 2012-05-03 00:42
Message generated for change (Comment added) made by jylaxx
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3523195&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 1.0.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Combined XY Plot Axis Display Area Problem

Initial Comment:
When I am using CombinedDomainXYPlot with a PeriodAxis, the starting and ending position of the axis seems not correct, with the starting position shifted a little bit to the left-side, and the ending position shifted to the right-side, i.e. the axis is longer than it should be, causing the ticks in between does not match exactly with the grid lines in the sub-plots.

When the same PeriodAxis is added to the sub-plots, this problem does not occur. All the demos under Combined Axis Charts in the JFreeChart 1.0.13 Demo Collection seems have these problem as well.


----------------------------------------------------------------------

Comment By: Jean-Yves LINET (jylaxx)
Date: 2012-08-04 08:32

Message:
A complete fix has to take care of the axisOffset.
I suggest a fixed code in attached file.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-05-15 02:52

Message:
Found a temporary workaround for the issue.

By overriding the draw() method and adjust dataArea before passing it to
super.draw():

dataArea.setRect(dataArea.getX()+4, dataArea.getY(), dataArea.getWidth()-8,
dataArea.getHeight());

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3523195&group_id=15494

[jfreechart-dev] [ jfreechart-Bugs-3552914 ] Incompatible licensed AGPL library itext used as dependency

[SourceForge.net <no...@so...>]

Bugs item #3552914, was opened at 2012-07-31 19:11
Message generated for change (Settings changed) made by mungady
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3552914&group_id=15494

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
Resolution: Rejected
Priority: 5
Private: No
Submitted By: Sergiu Dumitriu (sdumitriu)
Assigned to: David Gilbert (mungady)
Summary: Incompatible licensed AGPL library itext used as dependency

Initial Comment:
iText is licensed under the AGPL, which means that any project that uses it becomes AGPL. Not only does this contradict JFreeChart''s license, but it's also a hidden dependency on an AGPL library that makes any other project that thinks it's only using LGPL-compatible libraries actually an AGPL project.

----------------------------------------------------------------------

Comment By: David Gilbert (mungady)
Date: 2012-08-01 11:18

Message:
The version of iText that we distribute is LGPL, only newer versions are
AGPL.  Also please note that iText is a dependency for the JFreeChart Demo
application, but not for JFreeChart itself.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115494&aid=3552914&group_id=15494