#335 Improvements in SWT

open
General (246)
5
2007-11-14
2007-09-13
Anonymous
No

Hi,

Here are some suggestions for improvements in ChartComposite.java

1.Generate Getter/Setters for
canvas, info and zoomable in ChartComposite

2.Change Visibility of displayPopupMenu to public

3. Change
canvas = new Canvas(this, SWT.DOUBLE_BUFFERED |SWT.NO_BACKGROUND);
to improve Performance

I Hope you think about these Changes.

Thanks in Advance
Hauke Sommer

Discussion

  • David Gilbert

    David Gilbert - 2007-11-14
    • assigned_to: nobody --> mungady
     
  • David Gilbert

    David Gilbert - 2007-11-14

    Logged In: YES
    user_id=112975
    Originator: NO

    Hi Hauke,

    I have a few comments:

    1(a) I'll add getCanvas() for the 1.0.7 release, but wasn't sure when setCanvas() would be necessary so maybe you can explain a use case for that;

    1(b) Likewise for getChartRenderingInfo() (which will mirror the ChartPanel implementation);

    1(c) I'll add is/setDomainZoomable() and is/setRangeZoomable() methods, to mirror ChartPanel.

    2 displayPopupMenu() - this is a bit of an odd method, in that it does two things: enables/disables the menu items, and shows the menu. Is there a case where you'd want external code to call that method? You can call getPopupMenu() and do what you like with the menu already.

    3. I'll add this for the 1.0.7 release.

    Regards,

    Dave Gilbert
    JFreeChart Project Leader

     

Log in to post a comment.