#888 Labels links don't meet section area for thin ring charts

closed-fixed
General (896)
5
2008-09-23
2008-09-21
No

Right now, label links always go 10% of the radius into the pie/ring. This is OK for pie chart. However, for rings with thickness (section depth) less than 10%, the edges point into the inside hole of the ring.

See attached image for an example.

A simple solution to this would be to let the links point into the middle of thin links.

Discussion

  • Christoph Beck

    Christoph Beck - 2008-09-21

    label link depth patch (against trunk)

     
  • Christoph Beck

    Christoph Beck - 2008-09-21

    Attaching simple path to fix this.

    The patch adds a protected getLabelSectionDepth() { return 0.1; } to PiePlot, which is then called by drawLeftLabels() and drawRightLabels(). RingPlot overrides getLabelSectionDepth() to return Math.min(super.getLabelLinkDepth(), getSectionDepth() / 2).
    File Added: label-link-depth.patch

     
  • Christoph Beck

    Christoph Beck - 2008-09-21

    File Added: label-link-depth2.png

     
  • Christoph Beck

    Christoph Beck - 2008-09-21

    Oops, the comment for the supplied patch talks about new method getLabelLinkDepth(), not getLabelSectionDepth(). Sorry.

     
  • David Gilbert

    David Gilbert - 2008-09-23

    Thanks for the report. I've committed the fix to Subversion for inclusion in the 1.0.12 release.

    Regards,

    Dave

     
  • David Gilbert

    David Gilbert - 2008-09-23
    • labels: --> General
    • assigned_to: nobody --> mungady
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks