#681 getLegendItemLabels method is never called

1.0.x
closed-fixed
General (896)
5
2006-10-17
2006-10-16
No

getLegendItemLabels is never called, so it's
questinable if it have any use:

[kubanek@isdclin3 jfree]$ grep -r getLegendItemLabels *
chart/plot/PiePlot.java: *
getLegendItemLabels() method (DG);
chart/plot/PiePlot.java: * 16-Jul-2002 : Added check
for null dataset in getLegendItemLabels() (DG);
data/general/Dataset.java: * 17-Nov-2001 : Added
getLegendItemCount() and getLegendItemLabels() methods,
data/general/Dataset.java: *
getLegendItemLabels() methods...leave this to client
code (DG);
data/jdbc/JDBCIntervalXYDataset.java: public
String[] getLegendItemLabels() {
data/jdbc/JDBCXYDataset.java: public String[]
getLegendItemLabels() {

All are only definitions, there is no call of that
method. Label generation seems to change to
getLegendItemLabelGenerator.

As this method is never called, it should be completly
removed from source code. I can submit patch if requested.

Discussion

  • David Gilbert

    David Gilbert - 2006-10-17
    • assigned_to: nobody --> mungady
    • status: open --> closed-fixed
     
  • David Gilbert

    David Gilbert - 2006-10-17

    Logged In: YES
    user_id=112975

    Thanks for the report. I've committed a patch to CVS to
    deprecate this method and the getLegendItemCount() method.
    This will be included in the 1.0.3 release.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks