#629 Please add URLEncoder.encode() to all generateURL() methods.

closed-fixed
General (896)
5
2007-04-17
2006-05-11
Anonymous
No

Hello.
I am an Chinese in Japan. I found a bug in every
generateURL() methods of XXXXXXURLGenerator classes.

now source code in generateURL() are following:

-------------------------------------------------
result += this.seriesParameterName + "=" +
seriesKey.toString();
-------------------------------------------------

CAN YOU CHANGE THEM TO FOLLOWING???

-------------------------------------------------
result += this.seriesParameterName + "=" +
URLEncoder.encode(seriesKey.toString());
-------------------------------------------------

thaks.

gjx1108@yahoo.co.jp

Discussion

  • ye238

    ye238 - 2007-04-14

    Logged In: YES
    user_id=1756739
    Originator: NO

    This is definitely an big issue, and I'm not sure why this has not been fixed.

    Although sometimes web browsers are smart about spaces in the query string, double or single quotes will difinitely cause problems even for non-international users.

    I volunteer to fix this and submit a patch.

     
  • David Gilbert

    David Gilbert - 2007-04-17

    Logged In: YES
    user_id=112975
    Originator: NO

    Thanks. I thought I'd fixed that one, but hadn't. I've committed a fix to CVS for inclusion in the 1.0.6 release.

    Regards,

    Dave Gilbert
    JFreeChart Project Leader

     
  • David Gilbert

    David Gilbert - 2007-04-17
    • labels: --> General
    • assigned_to: nobody --> mungady
    • status: open --> closed-fixed
     
  • ye238

    ye238 - 2007-04-17

    Logged In: YES
    user_id=1756739
    Originator: NO

    Dave,

    I actually fixed it and was going to submit a patch. But I just looked and you seem to have fixed it yourself.

    Thanks!

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks