From: SourceForge.net <no...@so...> - 2007-12-31 14:54:51
|
Bugs item #1548836, was opened at 2006-08-29 21:30 Message generated for change (Settings changed) made by eelco12 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=682377&aid=1548836&group_id=118870 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: EndreStølsvik (stolsvik) Assigned to: Nobody/Anonymous (nobody) Summary: Support for Jetty 6 Initial Comment: It would be _very_ nice if the JettyLauncher supported Jetty 6. ---------------------------------------------------------------------- Comment By: Jax (ojacquet) Date: 2007-02-23 15:54 Message: Logged In: YES user_id=1121397 Originator: NO I've added a search path by first matching against: Pattern.matches("jetty-?[^-]*\\.jar", name); in a FilenameFilter and if that doesn't work it tries "org.mortbay.jetty.jar". This seems to work but there are a couple of other things not working either. Anyway, I'm on it :) I've got the build system working as well so maybe I can release an alpha version with jetty 6 and java 6 support in a while. ---------------------------------------------------------------------- Comment By: Jax (ojacquet) Date: 2007-02-23 11:55 Message: Logged In: YES user_id=1121397 Originator: NO The patch adds a helper method. If someone can provide an implementation for getJettyJarLocation I can add it. ---------------------------------------------------------------------- Comment By: Jax (ojacquet) Date: 2007-02-23 11:54 Message: Logged In: YES user_id=1121397 Originator: NO File Added: jettylauncher.patch ---------------------------------------------------------------------- Comment By: Eric Walker (ewalk153) Date: 2007-01-08 20:47 Message: Logged In: YES user_id=251808 Originator: NO To solve the problem in the plugin, it would require more work than simply changing the Utils class. For example, /com.iw.plugins.jettylauncher/src/com/iw/plugins/jetty/launcher/JettyClasspathProvider.java references the .jar name. Perhaps, this could be abstracted with a helper class for different configuration sets. I can confirm that changing the .jar name to org.mortbay.jetty.jar works with Jetty 6.1. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-12-22 10:20 Message: Logged In: NO Jetty changed the naming convention for the jetty.jar between 5 and 6. I find that the plugin works if I just change the name (or make a copy) of jetty.jar to the value it had in version 5 (org.mortbay.jetty.jar). A patch would probably be straightforward - it would only affect Utils.getJettyJar. I would have a crack myself, but I'm not really an Eclipse plugin expert, and I'm sure someone esle who is can find a better way to locate the jetty jar. It's name is now (following m2 conventions) jetty-<versionId>.jar. So you have to know the version before you locate the jar, or else just try all jars with that pattern. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2006-11-07 06:01 Message: Logged In: NO Eclipse3.2.1+Jetty6.0.1+JettyLauncher1.4.1 does not work. ---------------------------------------------------------------------- Comment By: Eelco Hillenius (eelco12) Date: 2006-08-29 23:12 Message: Logged In: YES user_id=820266 Yeah. I don't know about the other's, but I'm still very tight in my time (in other words, I can't work on it). Patches are welcome. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=682377&aid=1548836&group_id=118870 |