[Jettylauncher-plugin] [ jettylauncher-Bugs-1458079 ] Support for Java 6.0

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Bugs item #1458079, was opened at 2006-03-25 00:52
Message generated for change (Settings changed) made by eelco12
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=682377&aid=1458079&group_id=118870

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Support for Java 6.0

Initial Comment:
I tried to a build from the latest checkout in Eclipse
3.2 M5 with Java 6.0 b76 and Jetty wasn't able to
determine the VM version when I tried to launch an app.

----------------------------------------------------------------------

Comment By: g zombi (zombi)
Date: 2007-12-10 00:27

Message:
Logged In: YES 
user_id=63880
Originator: NO

Please, anyone ... upload that jar file to the update site. I'm not able
to build the plugin locally :(

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-07-15 17:34

Message:
Logged In: NO 

I have Eclipse 3.3 in order to fix this. I changed getVMType in
JettyClasspathProvider

import org.eclipse.jdt.launching.IVMInstall2;

 private int getVMType(ILaunchConfiguration config)
    {
    	 String versionString = null;

    	IVMInstall install = JavaRuntime.getDefaultVMInstall();
    	if (install instanceof IVMInstall2) {
    		IVMInstall2 install2 = (IVMInstall2)install;
    		versionString = install2.getJavaVersion();
    	    if (versionString.indexOf("1.1") > 0)
            {
                return VM_11;
            }
            else if (versionString.indexOf("1.2") >= 0 ||
versionString.indexOf("1.3") >= 0)
            {
                return VM_12_13;
            }
            else if (versionString.indexOf("1.4") >= 0 ||
versionString.indexOf("1.5") >= 0
                    || versionString.indexOf("1.6") >= 0 ||
versionString.equals("???"))
            {
                return VM_14_15_16;
            }
    	}
	 return VM_ERROR;
    }

----------------------------------------------------------------------

Comment By: Jax (ojacquet)
Date: 2007-02-21 22:30

Message:
Logged In: YES 
user_id=1121397
Originator: NO

I dropped you a line through the sourceforge contact page. I hope it
reaches you. Subject was "jettylauncher".

----------------------------------------------------------------------

Comment By: Eelco Hillenius (eelco12)
Date: 2007-02-21 18:33

Message:
Logged In: YES 
user_id=820266
Originator: NO

Cool. We are still looking for people to take over the project. There
seems to be enough interest in it, but the committers (all three) just
can't get to support this anymore. Please drop me a line when you are
interested.

----------------------------------------------------------------------

Comment By: Jax (ojacquet)
Date: 2007-02-21 17:49

Message:
Logged In: YES 
user_id=1121397
Originator: NO

Here http://jax.be/jettylauncher.jar is an updated jar file where the
versionString.equals("???") has been changed to
versionString.indexOf("1.6") >= 0. It doubled in size after I updated it
when the newly compiled JettyClasspathProvider.class but it works!

Put it in eclipse/plugins/com.iw.plugins.jettylauncher_1.4.1.


----------------------------------------------------------------------

Comment By: Jax (ojacquet)
Date: 2007-02-16 18:32

Message:
Logged In: YES 
user_id=1121397
Originator: NO

Any news on when/if this patch is going to make it?

----------------------------------------------------------------------

Comment By: Jonathan A. Leaver (eldaaran)
Date: 2006-12-08 01:24

Message:
Logged In: YES 
user_id=1352136
Originator: NO

Yes, in fact, changing line 397 from:

|| versionString.equals("???"))

to:

|| versionString.indexOf("1.6") >= 0 || versionString.equals("???"))

and recompiling the plugin definitely fixes this problem.

Here's what I've got:

### Eclipse Workspace Patch 1.0
#P com.iw.plugins.jettylauncher
Index: src/com/iw/plugins/jetty/launcher/JettyClasspathProvider.java
===================================================================
RCS file:
/cvsroot/jettylauncher/com.iw.plugins.jettylauncher/src/com/iw/plugins/jetty/launcher/JettyClasspathProvider.java,v
retrieving revision 1.19
diff -u -r1.19 JettyClasspathProvider.java

--- src/com/iw/plugins/jetty/launcher/JettyClasspathProvider.java	11 Oct
2004 10:41:46 -0000	1.19
+++ src/com/iw/plugins/jetty/launcher/JettyClasspathProvider.java	8 Dec
2006 00:23:59 -0000
@@ -394,7 +394,7 @@
             return VM_12_13;
         }
         else if (versionString.indexOf("1.4") >= 0 ||
versionString.indexOf("1.5") >= 0
-                || versionString.equals("???"))
+                || versionString.indexOf("1.6") >= 0 ||
versionString.equals("???"))
         {
             return VM_14_15;
         }


----------------------------------------------------------------------

Comment By: Jonathan A. Leaver (eldaaran)
Date: 2006-12-08 00:34

Message:
Logged In: YES 
user_id=1352136
Originator: NO

I did some research, and it looks like the virtual machine versions are
hard coded into the com.iw.plugins.jetty.launcher.JettyClasspathProvider
class.  If you scroll to the very end, it's probably a simple fix.  I bet
assuming that a 1.6VM behaves the same as a 1.5VM would pretty much solve
our problem.  Sun has gone to extraordinary lengths to make sure Java 6.0
has the fewest possible regressions over Java 5.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=682377&aid=1458079&group_id=118870


