From: Greg W. <gr...@mo...> - 2004-04-28 10:28:14
|
Martin, I hear what you are saying and agree that it would be good to avoid letting a webapp lock up the whole container. So the fact that the ThreadPool is locking the thread itself is something that I will look at avoiding (or using some other object instead). But I'm not going to rush into this - as everytime I add features the the threadpool instability results. I am still flushing out the last of the bugs from the result of adding the sharable thread pools! It may be a difficult task to make sure that the container never exposes any objects that it synchronizes on. It would be an interesting exercise to do something like getting and holding a lock on the system classloader and seeing what breaks? Perhaps Sun have had the disipline to use private lock members from the start. At the end of the day, it is very difficult to protect the container from bad code. A webapp can always exhaust memory or go into a busy loop and cause problems for other webapps. but at the very least, I'll try to make sure that ThreadPool can shutdown even if it is deadlocked. cheers Martin Roos wrote: > i'm not saying that jetty's synchronization is built up by the wrong > methods. > it seems to work very fast & fine. the only thing is that imho an webapp > shouldn't be able to shutdown the whole servlet-container so it would stop > responding. > also jetty should be able to shutdown even if some servlet has > created a big lockup in itself. > > Martin. > > Chris Haynes wrote: > >> Synchronization is usually only applied for a very good reason, as >> Greg is >> always aware of its performance implications.. >> >> Sounds to me like Jetty is doing a very good (& necessary) job of >> protecting >> itself from your fishing around in its ThreadPool ;-)) >> >> Chris >> > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click > _______________________________________________ > Jetty-support mailing list > Jet...@li... > https://lists.sourceforge.net/lists/listinfo/jetty-support > |