It appears that test/src is missing missing from the 3.2 distribution. Is this intentional? I package jericho-html for Fedora and had been running the test suite as part of the rpm build.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Sorry it was an accidental omission. I just overwrote the download bundle with one that includes it so try downloading it again. (I suspect that's a bit of a no-no but much easier than a new release!)
If it still doesn't contain the test directory you may need to wait until it popagates to other mirrors (not sure how that works exactly), or let me know and I'll send it to you.
Cheers
Martin
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
+ javac -Xlint -g -d test/classes test/src/StAXTest.java test/src/TestSuite.java test/src/samples/HTMLSanitiserTest.java test/src/net/htmlparser/jericho/CharacterReferenceTest.java test/src/net/htmlparser/jericho/MicrosoftConditionalCommentTagTypesTest.java test/src/net/htmlparser/jericho/NodeIteratorTest.java test/src/net/htmlparser/jericho/RendererTest.java test/src/net/htmlparser/jericho/SegmentGetStyleURISegmentsTest.java test/src/net/htmlparser/jericho/SegmentTest.java test/src/net/htmlparser/jericho/StreamedParseTextTest.java test/src/net/htmlparser/jericho/StreamedSourceHugeFileTest.java test/src/net/htmlparser/jericho/StreamedSourceTest.java test/src/net/htmlparser/jericho/StreamedTextTest.java
test/src/net/htmlparser/jericho/CharacterReferenceTest.java:12: warning: unmappable character for encoding ASCII
assertEquals("x?x",CharacterReference.decode("x€x")); // decode character entity reference with codepoint > U+00FF
^
test/src/net/htmlparser/jericho/CharacterReferenceTest.java:13: warning: unmappable character for encoding ASCII
assertEquals("x?x",CharacterReference.decode("x€x")); // decode decimal numeric character reference with codepoint > U+00FF
^
test/src/net/htmlparser/jericho/CharacterReferenceTest.java:14: warning: unmappable character for encoding ASCII
assertEquals("x?x",CharacterReference.decode("x€x")); // decode hexadecimal numeric character reference with codepoint > U+00FF
^
test/src/net/htmlparser/jericho/CharacterReferenceTest.java:31: warning: unmappable character for encoding ASCII
assertEquals("x? x",CharacterReference.decode("x€ x",false)); // decode unterminated decimal numeric character reference with codepoint > U+00FF with insideAttributeValue=false
^
test/src/net/htmlparser/jericho/CharacterReferenceTest.java:39: warning: unmappable character for encoding ASCII
assertEquals("x? x",CharacterReference.decode("x€ x",true)); // decode unterminated decimal numeric character reference with codepoint > U+00FF with insideAttributeValue=false
^
test/src/net/htmlparser/jericho/CharacterReferenceTest.java:40: warning: unmappable character for encoding ASCII
assertEquals("x? x",CharacterReference.decode("x€ x",true)); // decode unterminated hexadecimal numeric character reference with codepoint > U+00FF with insideAttributeValue=false
^
test/src/net/htmlparser/jericho/RendererTest.java:348: warning: unmappable character for encoding ASCII
return '?'+alt+'?';
^
test/src/net/htmlparser/jericho/RendererTest.java:348: warning: unmappable character for encoding ASCII
return '?'+alt+'?';
^
test/src/net/htmlparser/jericho/RendererTest.java:351: warning: unmappable character for encoding ASCII
assertEquals("x ?a picture? y",customRenderer.toString());
^
test/src/net/htmlparser/jericho/RendererTest.java:351: warning: unmappable character for encoding ASCII
assertEquals("x ?a picture? y",customRenderer.toString());
^
test/src/net/htmlparser/jericho/NodeIteratorTest.java:168: warning: [deprecation] LegacyIteratorCompatabilityMode in net.htmlparser.jericho.Source has been deprecated
Source.LegacyIteratorCompatabilityMode=true;
^
test/src/net/htmlparser/jericho/NodeIteratorTest.java:170: warning: [deprecation] LegacyIteratorCompatabilityMode in net.htmlparser.jericho.Source has been deprecated
Source.LegacyIteratorCompatabilityMode=false;
^
12 warnings
+ java -classpath classes:samples/console/classes:/usr/share/java/junit4.jar:test/classes -Djava.util.logging.config.file=test/logging.properties org.junit.runner.JUnitCore TestSuite
JUnit version 4.8.2
..E.E..........................................
Time: 0.291
There were 2 failures:
1) testDecode(net.htmlparser.jericho.CharacterReferenceTest)
org.junit.ComparisonFailure: expected:<x[?]x> but was:<x[?]x>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at net.htmlparser.jericho.CharacterReferenceTest.testDecode(CharacterReferenceTest.java:12)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at org.junit.runner.JUnitCore.run(JUnitCore.java:136)
at org.junit.runner.JUnitCore.run(JUnitCore.java:117)
at org.junit.runner.JUnitCore.runMain(JUnitCore.java:98)
at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:53)
at org.junit.runner.JUnitCore.main(JUnitCore.java:45)
2) testDecodeUnterminated(net.htmlparser.jericho.CharacterReferenceTest)
org.junit.ComparisonFailure: expected:<x[?] x> but was:<x[?] x>
at org.junit.Assert.assertEquals(Assert.java:123)
at org.junit.Assert.assertEquals(Assert.java:145)
at net.htmlparser.jericho.CharacterReferenceTest.testDecodeUnterminated(CharacterReferenceTest.java:31)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:616)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:24)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at org.junit.runner.JUnitCore.run(JUnitCore.java:136)
at org.junit.runner.JUnitCore.run(JUnitCore.java:117)
at org.junit.runner.JUnitCore.runMain(JUnitCore.java:98)
at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:53)
at org.junit.runner.JUnitCore.main(JUnitCore.java:45)
FAILURES!!!
Tests run: 45, Failures: 2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The javadoc still seems to be having trouble but I have no idea why.
I would question however whether there's any point at all including this library in an rpm. It is only used by developers, and any developers who need it can easily download it themselves. The javadoc included in the download has been customised for readability which is lost if it is being regenerated. In my opinion it's actually counterproductive to rebuild it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It appears that test/src is missing missing from the 3.2 distribution. Is this intentional? I package jericho-html for Fedora and had been running the test suite as part of the rpm build.
Sorry it was an accidental omission. I just overwrote the download bundle with one that includes it so try downloading it again. (I suspect that's a bit of a no-no but much easier than a new release!)
If it still doesn't contain the test directory you may need to wait until it popagates to other mirrors (not sure how that works exactly), or let me know and I'll send it to you.
Cheers
Martin
Thanks, but now I get failures:
+ javac -Xlint -g -d test/classes test/src/StAXTest.java test/src/TestSuite.java test/src/samples/HTMLSanitiserTest.java test/src/net/htmlparser/jericho/CharacterReferenceTest.java test/src/net/htmlparser/jericho/MicrosoftConditionalCommentTagTypesTest.java test/src/net/htmlparser/jericho/NodeIteratorTest.java test/src/net/htmlparser/jericho/RendererTest.java test/src/net/htmlparser/jericho/SegmentGetStyleURISegmentsTest.java test/src/net/htmlparser/jericho/SegmentTest.java test/src/net/htmlparser/jericho/StreamedParseTextTest.java test/src/net/htmlparser/jericho/StreamedSourceHugeFileTest.java test/src/net/htmlparser/jericho/StreamedSourceTest.java test/src/net/htmlparser/jericho/StreamedTextTest.java test/src/net/htmlparser/jericho/CharacterReferenceTest.java:12: warning: unmappable character for encoding ASCII assertEquals("x?x",CharacterReference.decode("x€x")); // decode character entity reference with codepoint > U+00FF ^ test/src/net/htmlparser/jericho/CharacterReferenceTest.java:13: warning: unmappable character for encoding ASCII assertEquals("x?x",CharacterReference.decode("x€x")); // decode decimal numeric character reference with codepoint > U+00FF ^ test/src/net/htmlparser/jericho/CharacterReferenceTest.java:14: warning: unmappable character for encoding ASCII assertEquals("x?x",CharacterReference.decode("x€x")); // decode hexadecimal numeric character reference with codepoint > U+00FF ^ test/src/net/htmlparser/jericho/CharacterReferenceTest.java:31: warning: unmappable character for encoding ASCII assertEquals("x? x",CharacterReference.decode("x€ x",false)); // decode unterminated decimal numeric character reference with codepoint > U+00FF with insideAttributeValue=false ^ test/src/net/htmlparser/jericho/CharacterReferenceTest.java:39: warning: unmappable character for encoding ASCII assertEquals("x? x",CharacterReference.decode("x€ x",true)); // decode unterminated decimal numeric character reference with codepoint > U+00FF with insideAttributeValue=false ^ test/src/net/htmlparser/jericho/CharacterReferenceTest.java:40: warning: unmappable character for encoding ASCII assertEquals("x? x",CharacterReference.decode("x€ x",true)); // decode unterminated hexadecimal numeric character reference with codepoint > U+00FF with insideAttributeValue=false ^ test/src/net/htmlparser/jericho/RendererTest.java:348: warning: unmappable character for encoding ASCII return '?'+alt+'?'; ^ test/src/net/htmlparser/jericho/RendererTest.java:348: warning: unmappable character for encoding ASCII return '?'+alt+'?'; ^ test/src/net/htmlparser/jericho/RendererTest.java:351: warning: unmappable character for encoding ASCII assertEquals("x ?a picture? y",customRenderer.toString()); ^ test/src/net/htmlparser/jericho/RendererTest.java:351: warning: unmappable character for encoding ASCII assertEquals("x ?a picture? y",customRenderer.toString()); ^ test/src/net/htmlparser/jericho/NodeIteratorTest.java:168: warning: [deprecation] LegacyIteratorCompatabilityMode in net.htmlparser.jericho.Source has been deprecated Source.LegacyIteratorCompatabilityMode=true; ^ test/src/net/htmlparser/jericho/NodeIteratorTest.java:170: warning: [deprecation] LegacyIteratorCompatabilityMode in net.htmlparser.jericho.Source has been deprecated Source.LegacyIteratorCompatabilityMode=false; ^ 12 warnings + java -classpath classes:samples/console/classes:/usr/share/java/junit4.jar:test/classes -Djava.util.logging.config.file=test/logging.properties org.junit.runner.JUnitCore TestSuite JUnit version 4.8.2 ..E.E.......................................... Time: 0.291 There were 2 failures: 1) testDecode(net.htmlparser.jericho.CharacterReferenceTest) org.junit.ComparisonFailure: expected:<x[?]x> but was:<x[?]x> at org.junit.Assert.assertEquals(Assert.java:123) at org.junit.Assert.assertEquals(Assert.java:145) at net.htmlparser.jericho.CharacterReferenceTest.testDecode(CharacterReferenceTest.java:12) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.junit.runner.JUnitCore.run(JUnitCore.java:157) at org.junit.runner.JUnitCore.run(JUnitCore.java:136) at org.junit.runner.JUnitCore.run(JUnitCore.java:117) at org.junit.runner.JUnitCore.runMain(JUnitCore.java:98) at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:53) at org.junit.runner.JUnitCore.main(JUnitCore.java:45) 2) testDecodeUnterminated(net.htmlparser.jericho.CharacterReferenceTest) org.junit.ComparisonFailure: expected:<x[?] x> but was:<x[?] x> at org.junit.Assert.assertEquals(Assert.java:123) at org.junit.Assert.assertEquals(Assert.java:145) at net.htmlparser.jericho.CharacterReferenceTest.testDecodeUnterminated(CharacterReferenceTest.java:31) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:24) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) at org.junit.runners.ParentRunner.run(ParentRunner.java:236) at org.junit.runner.JUnitCore.run(JUnitCore.java:157) at org.junit.runner.JUnitCore.run(JUnitCore.java:136) at org.junit.runner.JUnitCore.run(JUnitCore.java:117) at org.junit.runner.JUnitCore.runMain(JUnitCore.java:98) at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:53) at org.junit.runner.JUnitCore.main(JUnitCore.java:45) FAILURES!!! Tests run: 45, Failures: 2For some reason your compiler is rejecting anything other than ascii characters in the source code.
I have changed the source code so it replaces non-ascii characters with unicode literals, so hopefully it should work now.
Great, that seems to have taken care of things. FWIW - you can check out full logs of the build here:
http://koji.fedoraproject.org/koji/getfile?taskID=3016279&name=build.log
According to your log the build is failing.
To fix it:
1. Include src/java/net/htmlparser/jericho/nodoc/ in the source path
2. Specify the following switch on the javac command line:
-encoding Windows-1252
Thanks. How about this: http://koji.fedoraproject.org/koji/getfile?taskID=3017230&name=build.log
The javadoc still seems to be having trouble but I have no idea why.
I would question however whether there's any point at all including this library in an rpm. It is only used by developers, and any developers who need it can easily download it themselves. The javadoc included in the download has been customised for readability which is lost if it is being regenerated. In my opinion it's actually counterproductive to rebuild it.
It is used by the openmailarchiva project and I was looking to package that at one point. May still do so someday.