#161 FTP plugin: Fix sorting by Last Modified

closed-accepted
None
5
2013-11-16
2013-11-16
Yihua Zhang
No

The bug comes from EntryCompare in VFSDirectoryEntryTableMode.java. In order to compare last modified data, the code cast the VFSFile to FileVFS.LocalFile and call the getModified() method, this will trigger exceptions when the VFSFile is actually an FtpDirectoryEntry which extends VFSFile.

To fix the bug, I added a new method called getModified() in VFSFile.java, all the implementation of VFSFile should overwrite this method, so that we don't need to cast the VFSFile anymore. Also some modifications are made in the plugin code.

There are two patches, one for the plugin code, one for jedit. Both of them are needed.

Discussion

  • Yihua Zhang

    Yihua Zhang - 2013-11-16

    patch for ftp

     
  • Yihua Zhang

    Yihua Zhang - 2013-11-16

    patch for jedit

     
  • Alan Ezust

    Alan Ezust - 2013-11-16
    • assigned_to: nobody --> ezust
     
  • Alan Ezust

    Alan Ezust - 2013-11-16
    • status: open --> closed-accepted
     
  • Alan Ezust

    Alan Ezust - 2013-11-16

    Committed 23337 to FTP plugin. Committed 23336 to jedit trunk. Thank you!

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks