#109 Whitespace plugin: Menu item for showing all whitespace

closed-accepted
WhiteSpace (1)
5
2012-02-10
2012-02-03
jsot
No

Enable showing of all whitespace characters as one item in plugin menu. Why one? Because then it be can switched on/off with one click/shortcut.
Patch is against sources from http://prdownloads.sourceforge.net/jedit-plugins/WhiteSpace-1.0.1.zip because I didn't find sources in Git repo

Discussion

  • jsot

    jsot - 2012-02-03
    • assigned_to: nobody --> nathanjones
     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-03

    Significant interface changes have been done recently. They were only in svn:

    https://jedit.svn.sourceforge.net/svnroot/jedit/plugins/WhiteSpace/trunk

    You reminded me that these changes were staying in repository too long, so I applied for Whitespace 1.0.2 release.

    Seems to me that the change you suggest is not necessary. After you check leading, inner and trailing spaces you are able to switch it on and off with a single menu action. Isn't it the same?

    Anyway, patches must be made against trunk, at least in a case when the code changed.

    Are you sure nathanjones will take care of the patch? It's better to leave "nobody".

     
  • jsot

    jsot - 2012-02-04

    @feature: It's not the same. Proposed change also works for tabs (leading, inner, trailing) and other whitespace. So with single menu action you are able to switch on/off display of all whitespace characters - spaces, tabs and other whitespace. Just like it works in Eclipse for example. In the current state you have to use three menu action to get the same result: Show space, Show tabs, Show other whitespace

    @trunk: Aha, I somehow assumed that the same code would be in git repo. Thanks for the push in right direction. I'll make patch against svn trunk then.

    @assign to nathan: I'm not sure at all. I just don't know how it goes here so I assigned it to nathan as one of the authors. I will change it to "nobody" as suggested.

     
  • jsot

    jsot - 2012-02-04
    • assigned_to: nathanjones --> nobody
     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-04

    The feature sounds reasonable.

    About the assignment, thanks for pointing in right direction :)
    The description for the tracker was misleading. I changed it.

     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-04
    • milestone: 1365846 -->
     
  • jsot

    jsot - 2012-02-04

    I added svn diff against latest trunk.

     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-10
    • labels: --> WhiteSpace
     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-10

    A hasty work. I see some doubled code in actions.xml. Please review a patch and submit it again.

     
  • jsot

    jsot - 2012-02-10

    Hasty indeed :) Sorry for that. Fixed patch submitted.

     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-10
    • status: open --> closed-accepted
     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-10

    Committed as r21110. It will be in the next release (current is 1.0.2).
    I only:
    - removed comments to method calls with self-explanatory names and added others
    - shortened the code to match the style of the previous actions

     
  • Jarek Czekalski

    Jarek Czekalski - 2012-02-10
    • assigned_to: nobody --> jarekczek
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks