It would be nice to see git blame in the textarea like we can for the SVN Plugin.
Yeah, blame would be awesome. I've thought about it but haven't had the time to sit down and code it.
The SVN plugin has a "blame" functionality close to what I'd want; but copying the code might have its problems since that plugin is GPL and GitPlugin is not. (Although I'm sure Dale would be OK with it, if all the code is his.)
I'm certainly okay with changing the license. As far as I'm concerned, any code that I've written for jEdit is fair to use anywhere else in jEdit, regardless of what license may be attached. That said, I've been really hard pressed to find much time to write code lately outside of work. I'll attempt to take this on, but don't expect quick results :)
I was thinking that if there was code that both SVN and GitPlugin could reuse for this feature, it could be located in CommonControls.
I looked through the svn plugin blame code, it should lift right out. The svn plugin has an action that calls an svn server, then populates a BlameModel with the answer from the server. There is nothing svn specific in the model or in the display code. It's really just a matter of writing a new action for getting the blame info from git, filling in a model, creating the UI components to attach to the text area, and it's done.
For reference, these are the 4 classes that are needed and all can be used virtually unchanged. Probably just need to change the package name.
This class is the one that gets the svn blame info and sets up the blame display and can be used as an example for a similar git action:
I have moved the Blame component from the SVN Plugin to CommonControls. The SVN Plugin now depends on CommonControls version 1.7. Next up is to write a blame command for the Git plugin.
If you have not started that part already, I can work on it.
If you have, then you can assign to yourself again.
I haven't, so go right ahead. I'll look into adding the tooltip you suggested.
Pushed to master. Will be in version 0.6.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.