#1618 XML: Completion popup for attributes after self-closed tag

closed-fixed
None
5
2013-02-18
2012-06-08
Alan Ezust
No

Rev# 21773 contains a new test case for attribute completion.
Completion popups appear after a self-closed <tag/> when they should not.

The test case is: no popup should appear on line 24 of test_data/attributes_completion/attributes.xml,
and yet, one does.

Discussion

  • Alan Ezust

    Alan Ezust - 2012-06-28
    • assigned_to: kerik-sf --> nobody
     
  • Alan Ezust

    Alan Ezust - 2012-06-29
    • assigned_to: nobody --> ezust
    • status: open --> closed-fixed
     
  • Alan Ezust

    Alan Ezust - 2012-06-29

    Committed 21888.

     
  • Eric Le Lay

    Eric Le Lay - 2012-07-10

    Alan, this fix prevents attribute completion when first attribute contains a '>' character (which is perfectly legal).
    see test_data/attributes_completion/attributes.xml, line 26 @r21929

     
  • Eric Le Lay

    Eric Le Lay - 2012-07-10
    • status: closed-fixed --> open-invalid
     
  • Alan Ezust

    Alan Ezust - 2012-08-03

    Can you please replace my one-liner almost-fix with something that works to your satisfaction?
    Assigning ticket to you...

     
  • Alan Ezust

    Alan Ezust - 2012-08-03
    • assigned_to: ezust --> kerik-sf
     
  • Eric Le Lay

    Eric Le Lay - 2012-08-26

    r22073 contains a fix.
    It's a big change, so may break other cases.
    I leave the ticket open for now.

    Except for comments,cdata and entities,
    XmlParser checks for token types and image to guess completion mode required (element, attribute).

    Two variants:
    - strict, working only for html,xml,xsl,ant,maven,tld
    - non strict, working with all of them + javadoc
    Strict was made to prevent unwanted completions, but non strict
    has more possibilities to adapt to other modes.

    Non-strict is on by default.
    If it works, it will stay so and strict mode will be removed.
    One can switch between strict and non strict by setting the boolean
    property "xml.try-modes-superset".

     
  • Eric Le Lay

    Eric Le Lay - 2012-09-16

    works for me with the patch...

     
  • Eric Le Lay

    Eric Le Lay - 2012-09-16
    • status: open-invalid --> pending-fixed
     
  • Eric Le Lay

    Eric Le Lay - 2013-02-18

    worked fine so far

     
  • Eric Le Lay

    Eric Le Lay - 2013-02-18
    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks