#479 Fix bug 3596616

closed
None
5
2013-03-16
2012-12-28
No

Fix the insert selection macro bug.

Discussion

  • Alan Ezust

    Alan Ezust - 2013-03-14

    No problems with this patch except for the 'null' on line 12 -
    jEdit.closeBuffer(null, b). Why not pass view as the first argument?

     
  • Alan Ezust

    Alan Ezust - 2013-03-14
    • assigned_to: nobody --> thomasmey
     
  • Alan Ezust

    Alan Ezust - 2013-03-14

    Also, it seems some parts of this macro were already modified between your patch submission and the present, so your diffs related to the getToolkit().beep() were rejected.

     
  • Thomas Meyer

    Thomas Meyer - 2013-03-16

    1.) Regarding the rejects: Yes, kpouer tried to fixed this, but missed the jEdit.close()
    2.) jEdit.closeBuffer() is called with null, because we have a temporary buffer here, which is not attached to a view.

     
  • Thomas Meyer

    Thomas Meyer - 2013-03-16

    commited as rev. 22845

     
  • Thomas Meyer

    Thomas Meyer - 2013-03-16
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks