Help save net neutrality! Learn more.
Close

#464 Fix window class on gnome/linux

closed-accepted
Damien
None
5
2012-11-29
2012-11-03
Damien
No

On Linux (especially with gnome shell), the application name isn't set correctly. Currently, it's being set to

org-gjt-sp-jedit-jEdit

This patch sets the window class to "jedit", which tells the window manager to pull the name from jedit.desktop, which is the much friendlier "jEdit".

Patch made with jEdit trunk revision 22411.

Discussion

  • Damien

    Damien - 2012-11-03
     
  • Anonymous - 2012-11-03

    Where do you see the application name? I am running on ubuntu 10.04 with gnome, and the title of the jEdit window is "jEdit - <path>". (where <path> is the path of the current buffer)

     
  • Damien

    Damien - 2012-11-05

    Updated to include check for X11 operating systems

     
  • Damien

    Damien - 2012-11-05

    GNOME 3 makes a distinction between window title and application name. This patch is meant to fix the application name, which is displayed on the top bar and not the window title.

    Doing a quick search to find other examples, it looks like this was actually suggested a couple years ago, but it doesn't look like it's been implemented yet: http://jedit.9.n6.nabble.com/jedit-Patches-2796960-X11-WMCLASS-td1800684.html

    As an aside, I updated the patch to include a check for X11 operating systems to make sure that this doesn't have any unexpected side-effects in other environments.

     
  • Alan Ezust

    Alan Ezust - 2012-11-11

    Will I see any difference from KDE? Because I am testing your patch with that and I don't know where to look.

     
  • Alan Ezust

    Alan Ezust - 2012-11-11
    • summary: Fix window class on linux --> Fix window class on gnome/linux
     
  • Anonymous - 2012-11-13

    I previously used GNOME 2 (Ubuntu 10.04) and now I use Unity (Ubuntu 12.04). In both, the name of the application is jEdit also without this patch (and this patch does not change it).
    I guess, if you have GNOME 3 and see the effects of this patch, go on and commit it...

     
  • Alan Ezust

    Alan Ezust - 2012-11-14

    assigning to kog13 since he has permission to commit it himself.

     
  • Alan Ezust

    Alan Ezust - 2012-11-14
    • assigned_to: nobody --> kog13
     
  • Damien

    Damien - 2012-11-29
    • status: open --> closed-accepted
     
  • Björn Kautler

    Björn Kautler - 2013-08-11

    With this "fix" you broke actually the proper integration with Unity and other desktop managers because you changed the Window Class without also changing the jedit.desktop file. Now you cannot dock jEdit and if you docked it before or docked it manually, the running jEdit instance will not be recognized as belonging to the docked button. :-(

     

Log in to post a comment.