#366 Suggested Fixes for PHP Syntax Highlight

closed-invalid
None
5
2012-04-22
2010-11-08
toBeGolden
No

Fixed for PHP, (a)that reserved words can not be used for class or function names (b) that class names cannot start with a digit. (c) however allowed class|function names that have a reserved word embedded in it (eg. "newStuff")

Discussion

  • toBeGolden

    toBeGolden - 2010-11-08

    Diff for both TokenMarker.java && php.xml

     
  • toBeGolden

    toBeGolden - 2010-11-08

    These fixes are intended to address item #305007. I guess that I should have attached the diff file to that bug item, rather than creating a new item (two new items as it turns out). I hope you can trust me that I almost always make these kinds of mistakes just once.

     
  • Alan Ezust

    Alan Ezust - 2011-08-29
    • assigned_to: nobody --> kpouer
     
  • Matthieu Casanova

    Hi, your patch seems invalid, and I don't see why the TokenMarker has to be modified to change the php highlight.

     
  • Matthieu Casanova

    • status: open --> pending-invalid
     
  • Jarek Czekalski

    Jarek Czekalski - 2012-04-22
    • status: pending-invalid --> closed-invalid
     

Log in to post a comment.