#360 NPE if mode has no FILE_NAME_GLOB

closed-fixed
7
2010-10-25
2010-10-08
No

I've got modes that don't have a FILE_NAME_GLOB (which I believe is optional) in catalog. jEdit dies during startup with an NPE on line 263 of Mode.java.

This appears to have been introduce in revision18093.

The attached patch fixes it by swapping the comparison (filename.equals(null) vs null.equals(filename)).

Discussion

  • Ollie Rutherfurd

     
    Attachments
  • Dale Anson

    Dale Anson - 2010-10-11

    I committed revision 18093, so I'll take a look at this one.

     
  • Dale Anson

    Dale Anson - 2010-10-11
    • assigned_to: nobody --> daleanson
     
  • Dale Anson

    Dale Anson - 2010-10-11

    I also have modes that don't have a FILE_NAME_GLOB, but I don't see the error. jEdit starts fine. Your patch looks good, though, it just concerns me that I can't reproduce this. Would you mind attaching your catalog file?

     
  • Dale Anson

    Dale Anson - 2010-10-21

    Applied to trunk in revision 18809. Leaving this open until it is applied on the 4.4.x branch.

     
  • Dale Anson

    Dale Anson - 2010-10-25

    Applied to 4.4.x branch in revision 18844.

     
  • Dale Anson

    Dale Anson - 2010-10-25
    • status: open --> closed-fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks