#324 Add descriptive titles to file browser dialogs

closed-accepted
general (64)
5
2012-01-24
2010-03-11
No

This is a patchset to implement the feature requested through SourceForge at http://sourceforge.net/tracker/?func=detail&aid=2807301&group_id=588&atid=350588. Essentially, the feature requests that the file browsing dialogs have more meaningful titles.

This patchset provides this enhancement through the addition of new GUI properties and modifications to the VFSFileChooserDialog.

Testing for this patchset was done incrementally after each patch. The application was tested to ensure that no unexpected outcomes occurred, and that the changes had the desired effect. Once all the patches were applied, more extensive testing was done to ensure the integrity of the patchset.

Originally, the feature request had three different titles: "File Browser - Open", "File Browser - Save" and "File Browser - Save As". However, since the VFSFileChooserDialog mode does not differ between the "Save As" or a "Save" actions no specific title was added for "Save As". Hence the possible titles are "File Browser - Open", "File Browser - Save", and the default "File Browser".

The implementation of this feature provides easy extendability. Any new modes for VFSBrowser can be added to both the VFSFileChooserDialog getTitle method and the GUI properties.

Changelog

* Added title selection based on mode for VFSFileChooserDialog
* Added titles to jedit_gui.props

Discussion

  • Anonymous - 2010-03-11

    Add descriptive titles to file browser dialogs

     
  • Anonymous - 2010-03-14

    As jEdit is not on git yet, please provide an SVN-compatible patch.

     
  • Marcelo Vanzin

    Marcelo Vanzin - 2010-03-15

    Shlomy, what do you mean? "patch" understands the attachment just fine.

     
  • Anonymous - 2010-03-15

    I'm on Windows, I don't have 'patch', just TortoiseSVN that I always use to apply patches. Looking at this patch directly (as text), I see the same file appearing twice. So this patch seems to include some irrelevant things.
    If 'patch' works for you, maybe you can review / apply it?

     
  • Anonymous - 2010-03-17

    Add descriptive titles to file browser dialogs (Compatible with SVN)

     
  • Anonymous - 2010-03-17

    I have added an SVN-compatible patch. Also, I cleaned up the patch to remove the duplicate files that shlomy mentioned. Initially I had the file showing twice to try and my work flow.

     
  • Anonymous - 2010-03-17

    Edit: I have added an SVN-compatible patch. Also, I cleaned up the patch to
    remove the duplicate files that shlomy mentioned. Initially I had the file
    appearing twice to try and show my work flow.

     
  • Alan Ezust

    Alan Ezust - 2010-12-12

    I tested your patch, and noticed 2 things.
    1. there are 2 identical property values in the jedit_gui.props.
    +vfs.browser.title.open=File Browser - Open
    +vfs.browser.title.dialog=File Browser - Open

    I don't understand why you need both of them.
    One of them seems to be for choose directory, but if that is the case, the property name should
    indicate that too.

    Also, when I am in projectviewer and I go "add files", I see nothing at all in the title bar of the dialog now.

     
  • Alan Ezust

    Alan Ezust - 2011-08-30
    • status: open --> pending-rejected
     
  • Alan Ezust

    Alan Ezust - 2011-08-30

    Marking as rejected/pending unless we get a resubmission.

     
  • Alan Ezust

    Alan Ezust - 2011-08-30

    ignore my previous comment about add files from projectviewer, that is
    nothing to do with this patch.

     
  • Alan Ezust

    Alan Ezust - 2011-08-30
    • status: pending-rejected --> open
     
  • Alan Ezust

    Alan Ezust - 2012-01-24
    • assigned_to: nobody --> ezust
    • status: open --> closed-accepted
     
  • Alan Ezust

    Alan Ezust - 2012-01-24

    Committed 20945

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks