#130 patch for ruby.xml mode (SVN r10429)

closed-accepted
general (64)
6
2008-09-03
2007-08-29
No

Hello,

Please see the attached patch (against SVN r10429) for the modes/ruby.xml file.

The first change surrounds the =begin and =end keywords with newlines because those keywords do not take any effect unless they are at the beginning of a line. If they appear in the middle of a line, it becomes a syntax error.

The second change is the addition of "initialize" as a second-order keyword. It is hard to type initialize correctly sometimes and so putting this word as a keyword2 gives two benefits:

1. I can use jEdit code completion to type the word:

[i] [n] [i] [t] [control][b]

2. I can easily see if the word is misspelled because it will only have syntax coloring if it is correctly spelled.

Please give your comments on these changes and if you like them, please incorporate them into the SVN trunk.

Thanks for your consideration.

Discussion

  • Suraj Kurapati

    Suraj Kurapati - 2007-08-29

    my patch

     
  • Alan Ezust

    Alan Ezust - 2007-09-06
    • assigned_to: nobody --> robmckinnon
     
  • Alan Ezust

    Alan Ezust - 2007-09-06

    Logged In: YES
    user_id=935841
    Originator: NO

    rob, can you please review this patch?

     
  • Alan Ezust

    Alan Ezust - 2007-09-06

    Logged In: YES
    user_id=935841
    Originator: NO

    rob, can you please review this patch?

     
  • Suraj Kurapati

    Suraj Kurapati - 2008-08-01

    Logged In: YES
    user_id=315014
    Originator: YES

    Any update on the status of accepting this patch?
    This is a trivial patch; it shouldn't take very long to review.

    On a side note, it's been so long since I submitted this patch (wow! almost a YEAR already!) that I had completely forgotten whether I actually submitted it or whether I merely *thought* about doing so. I actually came back to (re)submit it just now and saw it was already there... deja vu! :-)

    Please review and accept this patch so that all Rubyists can benefit from it!

     
  • Suraj Kurapati

    Suraj Kurapati - 2008-08-01
    • labels: --> general
    • priority: 5 --> 6
     
  • Kazutoshi Satoda

    Logged In: YES
    user_id=1483238
    Originator: NO

    About the change for =begin and =end, I'm not sure about its benefits.
    With this patch, these words at the middle of line still highlighted as
    start and end of range comments. Nothing changed. I found a difference
    on [Range comment] action. But I'm not sure whether it is intended
    because the result becomes a bit odd (with spaces jEdit inserts and a
    blank line).

    Adding "initialize" looks fine. Accepted in r13156.

    Please clarify the actual benefits of the first change.

     
  • Kazutoshi Satoda

    • assigned_to: robmckinnon --> k_satoda
    • status: open --> open-accepted
     
  • Kazutoshi Satoda

    • status: open-accepted --> pending-accepted
     
  • Kazutoshi Satoda

    Logged In: YES
    user_id=1483238
    Originator: NO

    Ping. (SF.net seems not sending notification for my last comment.)
    Setting this to Pending because I can't work on this without more
    information.

     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending-accepted --> closed-accepted
     
  • Suraj Kurapati

    Suraj Kurapati - 2009-08-28

    I understand that without this patch, the =begin and =end delimiters are syntax highlighted correctly regardless of whether they appear at the beginning of a line or not.

    The problem is that if they cause a syntax error unless they appear at the beginning of a line. So the C-e C-c (range comment) action should take care of this by ensuring that these delimiters appear at the beginning of a line.

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks