[ jEdit-devel ] [ jedit-Patches-3543524 ] "Whole word" option does not work in Replace

[SourceForge.net <no...@so...>]

Patches item #3543524, was opened at 2012-07-13 06:34
Message generated for change (Comment added) made by 
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3543524&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: texteditor
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Malathi ()
Assigned to: Jarek Czekalski (jarekczek)
Summary: "Whole word" option does not work in Replace

Initial Comment:
Problem:
Trying to replace all occurrences of "debug_client" with "DebugClient", when the "Whole word" option is selected in the Search&Replace dialog, causes also partial word replacements. E.g. both of the following were replaced:

genericapi: debug_client
genericapi_all: debug_client_all

Note that in the 2nd line, debug_client does not appear as a whole word.

Patch:
The _replace() method in SearchAndReplace.java file noWordSep is assigned with wordBreakChars. So i changed it to assign noWordSep

----------------------------------------------------------------------

>Comment By: Malathi ()
Date: 2012-07-29 17:45

Message:
The reason I included "noWordSep.isEmpty()" is that before changing
WordBreakChars to noWordSep in _replace() the value that noWordSep get in
setNoWordSep is an empty string(because wordBreakChars is empty in
jedit.props). At that time if "noWordSep == null" condition only is
checked, then noWordSep is assigned with the empty string. To avoid that i
included "noWordSep.isEmpty()" condition as a precautionary. If I am wrong
clarify me. Thanks

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-07-29 11:24

Message:
Malahti, you found and fixed an evident bug. Thanks for that. But I wonder
if this change is good:

-		if (noWordSep == null)
+		if (noWordSep == null || noWordSep.isEmpty())

That means that user will not be able to treat _ as a non-word character.
Even if he leaves "Extra word characters" empty, the underscore will still
be treated as being part of the word. _ is a default "Extra word character"
(see jedit.props), isn't it enough?

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-07-27 10:56

Message:
This is a patch for bug #3543524
https://sourceforge.net/tracker/index.php?func=detail&aid=3522497&group_id=588&atid=100588

----------------------------------------------------------------------

Comment By: Malathi ()
Date: 2012-07-13 23:39

Message:
Hey I am creating this patch with the version 4.5.2

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3543524&group_id=588