[ jEdit-devel ] [ jedit-Plugin Patches-3520045 ] Forward/back file actions for Navigator

[SourceForge.net <no...@so...>]

Plugin Patches item #3520045, was opened at 2012-04-21 02:08
Message generated for change (Comment added) made by tp21
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3520045&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tom Power (tp21)
Assigned to: Dale Anson (daleanson)
Summary: Forward/back file actions for Navigator

Initial Comment:
Adds actions to go forward or back a whole file in the Navigator history. Keeps track of where in the history the action was called and makes use of that in subsequent calls to the action. Useful when you have alot of history in a single file, and don't want to go through it to get to "that" file you were just working on.

----------------------------------------------------------------------

>Comment By: Tom Power (tp21)
Date: 2012-06-21 11:12

Message:
Thanks for the comments both of you, with the fileJump marker I was trying
to ensure you got back to the location you were most recently, but in the
file you'd jumped from, as that seems better to me.  I mainly had in mind
tying them to keys for flicking between files without thinking too much.
For additional scenarios, I'd say whenever you use the actions to exit a
file and there are history items between your current location and the file
you're going to.

For your qu's Jarek:

First scenario: I think I'd be less surprised by returning to where I'd
jumped from, than the last/first place I'd been since being in that file. 

So yes I think it'd be desirable and no I think I'd prefer to use
goBack/goForward afterwards to get to my starting location.

Second scenario: I totally agree, hadn't thought about that and it doesn't
work there. I think calling removeFileJumps() whenever you left a file by a
method other than goFowardFile()/goBackFile() would fix it and happy to try
to implement though don't want to cause more probs :¬)










----------------------------------------------------------------------

Comment By: Dale Anson (daleanson)
Date: 2012-06-21 09:10

Message:
Actually, I like this patch quite a lot. It provides the functionality of
'group by file' on the fly so you still have the granularity of jumping by
caret position or line. Even better than 'group by file', it takes you back
to the last position you visited in the file rather than the last position
in the history for that file, which is very convenient.

I agree with Jarek, this is a little hard to explain for the help file
documentation, but if you show the Navigator dockable, it's pretty obvious
what's going on. I'll try to write up something coherent before committing.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-06-21 08:26

Message:
Introducing fileJump marker adds a significant complication to the code.
But let's forget about it for a moment and think of very user interface.

Let's consider the following scenario:
1. User does goBack several times still being in file A. They think: I'd
rather jump fileBack to B.
2. He does goBackFile
3. He does goForwardFile hoping to reach the location he started moving
from

Without fileJump marker he would get to the most recent history entry for
that file. With marker he lands back several steps. So the questions
arise:
A. Is it desired?
B. If yes, should they have the possibility to go fileForward once more to
land on the top of the history?

Could you give one scenario where fileJump is really needed and jumping to
most recent entry should be avoided?

I think I have another scenario where the marker might be misleading:
1. goBackFile to file B (sets marker in file A)
2. goForwardFile to file A
3. Travel through file A manually marking new positions
4. goBack (not file) many times, stop in file B
5. goForwardFile to land in file A. Landing in position from 1 (not the
position after 3) may be a surprise

And it's a bit harder to explain (in user docs) what is exactly the place
fileBack/fileForward jumps to. I think the place where the user lands in
should be easily predictable. But maybe I'm wrong. Let Dale decide.

----------------------------------------------------------------------

Comment By: Tom Power (tp21)
Date: 2012-06-21 07:21

Message:
Hi, it's used when the user jumps back to a file they've recently jumped
from, found it nicer when doing that than putting the user at the
first/last history item in the file they're jumping to, added a comment
that hopefully makes clearer

----------------------------------------------------------------------

Comment By: Dale Anson (daleanson)
Date: 2012-06-21 07:07

Message:
Tom, thanks, I'll review this morning.

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-06-21 06:33

Message:
Tom, what would happen if you didn't have fileJump marker? I guess
something terrible, but can't imagine what it is. Maybe a comment could
enlighten it?

----------------------------------------------------------------------

Comment By: Tom Power (tp21)
Date: 2012-06-21 03:21

Message:
This works well for me now, what do you think Dale, I can commit it if
easier?

----------------------------------------------------------------------

Comment By: Alan Ezust (ezust)
Date: 2012-05-23 10:24

Message:
When fixed, please create a new ticket, and assign your patch to dale anson
for review, he is maintainer of Navigator.



----------------------------------------------------------------------

Comment By: Tom Power (tp21)
Date: 2012-05-19 04:23

Message:
Isn't OK, I still want an action like this but this patch has bugs!

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-05-19 04:01

Message:
Tom, please review for the last time whether all is ok, as it is a bit old.
I believe no one objects you committing to unmaintained plugins directly,
so please do.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=3520045&group_id=588