[ jEdit-devel ] [ jedit-Patches-3527512 ] Fixed printing page range bug

[SourceForge.net <no...@so...>]

Patches item #3527512, was opened at 2012-05-17 00:50
Message generated for change (Comment added) made by jarekczek
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3527512&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Pending
>Resolution: Rejected
Priority: 5
Private: No
Submitted By: Paul (pdvu)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fixed printing page range bug

Initial Comment:
The attached file is a patch for bug ID: 1697462. Added variables that adjust the printing area to its correct position after some calculations. Tested in jEdit 5.0pre1. 

----------------------------------------------------------------------

>Comment By: Jarek Czekalski (jarekczek)
Date: 2012-05-17 11:56

Message:
So I make the entry pending. If you are ready with the patch in 2 weeks or
so, reopen it. If it becomes closed, ask through a comment to reopen it.

----------------------------------------------------------------------

Comment By: Paul (pdvu)
Date: 2012-05-17 10:16

Message:
This is still an issue in the original code, this addresses page
orientation and printing in the correct range(ex print pages 3 to 4). I can
look for a solution to the text wrapping issue. 

----------------------------------------------------------------------

Comment By: Jarek Czekalski (jarekczek)
Date: 2012-05-17 01:13

Message:
To me it would be more readable if linePerPage was initially -1. It would
make "locked" field unnecessary. What do you think about it, Paul?

Did you tested against wrapped lines, when physical line is not equal to a
visible one?

Seems like the code
currentPage = pageIndex;
is duplicated.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3527512&group_id=588