Re: [ jEdit-devel ] copy method creating vfs session out of awt thread

[Jarek C. <jar...@po...>]

W dniu 04/30/2012 10:34 AM, Jarek Czekalski pisze:
> W dniu 2012-04-30 10:24, Matthieu Casanova pisze:
>> You're right that's something I probably didn't think about when I 
>> did it, probably because the session really need to be obtained on 
>> EDT thread if it really create a dialog, and ftp plugin is the only 
>> plugin I know that do that it probably never happened to me.
>> So I don't know if the best is to change the doc to call this method 
>> on EDT thread or use invokeAndWait(), the problem is that if the 
>> entire copy is done on EDT it will freeze jEdit.
> You don't need to place entire copy in edt, just the createsession 
> part. invokeAndWait equivalent seems a way to go.
>
> I was also thinking about only conditionally entering edt thread, when 
> the VFS is not instanceof builtin FileVFS.
Or a better, general solution. I could add NON_EDT_SESSION capability. 
It would be set for most filesystems, but not for FTP. Do you think it's 
a good idea? I'm in process of coding it.

Jarek
>
> Answering your question from tracker: it is that method, the same as here.
>
> Jarek
>>
>> 2012/4/29 Jarek Czekalski <jar...@po... 
>> <mailto:jar...@po...>>
>>
>>     Matthieu, you created those methods long time ago, r5233.
>>
>>     One of the variants of copy creates sessions, using createVFSSession.
>>     But the documentation of VFS states that the session must be
>>     obtained in
>>     awt thread. Should this place be corrected so that sessions were
>>     obtained in awt thread?
>>
>>     Jarek
>>
>>     ------------------------------------------------------------------------------
>>     Live Security Virtual Conference
>>     Exclusive live event will cover all the ways today's security and
>>     threat landscape has changed and how IT managers can respond.
>>     Discussions
>>     will include endpoint security, mobile security and the latest in
>>     malware
>>     threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>>     --
>>     -----------------------------------------------
>>     jEdit Developers' List
>>     jEd...@li...
>>     <mailto:jEd...@li...>
>>     https://lists.sourceforge.net/lists/listinfo/jedit-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>
>