From: Dalibor P. <dal...@is...> - 2008-04-17 08:04:17
|
Original message from Kazutoshi Satoda, sent on 16.4.2008 20:32 > Kazutoshi Satoda wrote: >> 1. Add a method like getPermissiveTextReader() to the interface >> Encoding, and adjust all implementations as such. This method returns >> a Reader which doesn't throw encoding-errors. It will replace or >> ignore broken bytes instead. >> 2. Add an option like do-permissive-reload-at-last in Encoding option >> pane. If this is checked, file is automatically reloaded with a >> permissive text reader of the buffer's encoding in the case an >> encoding-error is shown now. This will be not checked by default, >> and mentioned in the encoding-error message, like "Annoyed? Try >> checking the option ...". >> >> I think the above satisfies the needs from those who don't want to see >> the encoding-error dialog. > > After re-thinking about the change of dialog (thanks Shlomy and Alan), > another idea came in my mind. > > After the step 1, it looks sufficient to do permissive reload without > condition. No new option is required. This way, the file is loaded (with > some replacements or loss of data), *and* the error is shown. > > I have missed the candidate "load with error", while thinking about two > other candidates; "just load (without error)" or "just error (without > load)". I'm sorry about how thoughtless I was... > > Obvious and the most valuable point of "load with error" solution is it > doesn't have issue about the change of UI (dialog). > > Re-reading the previous thread, it seems that no one said "I don't want > to see the encoding error". However, if someone say so, adding a new > option like dont-show-encoding-error will be still possible. Please let > me know if someone want it. If it's not too much of work, I'd like to see this option implemented. Otherwise, I'm very glad how thing are going regarding this issue. Keep up a good work! Thanks, -- Dalibor Petričević |