From: Suraj N. K. <sn...@gn...> - 2008-05-30 04:47:24
|
Hi, SVN r12708 seems to have broken the ability to ascend to the parent directory by pressing the left-arrow key in the Open File dialog box. Was this intentional? Thanks for your consideration. ------------------------------------------------------------------------ r12708 | ezust | 2008-05-26 19:48:54 -0700 (Mon, 26 May 2008) | 3 lines [ 1694133 ] File Browser: back-arrow in filename textbox ------------------------------------------------------------------------ |
From: Suraj N. K. <sn...@gn...> - 2008-05-30 05:54:57
|
Alan Ezust wrote: > Suraj N. Kurapati wrote: >> SVN r12708 seems to have broken the ability to ascend to the >> parent directory by pressing the left-arrow key in the Open >> File dialog box. Was this intentional? > > You mean in the textfield? It should still work when other > components have focus. I just tried a clean build of r12731 and the left-arrow key does nothing. Similarly, the new / and - and ~ shortcuts (which correspond to the items in the "Commands" menu of the File Browser dialog) also do nothing. In addition, when focus is on a tree item in the tree-view, pressing the above shortcuts simply emits that particular key in the "file name" text box. i.e. click on a tree item and press ~ and ~ will appear in the "file name" text box. I am using: java version "1.6.0_03" Java(TM) SE Runtime Environment (build 1.6.0_03-b05) Java HotSpot(TM) Client VM (build 1.6.0_03-b05, mixed mode, sharing) > This was in response to a bug report > http://sourceforge.net/tracker/index.php?func=detail&aid=1694133&group_id=588&atid=100588 The reporter of that bug mentioned that, for him, pressing left-arrow would make the File Browser navigate to the root of his file system. For me, pressing the left-arrow always made the File Browser ascend by a single level only. This is a feature I use excessively and my ability to navigate the file system is greatly hindered without it: I am now forced to take my hand off the keyboard, move the mouse, and click on things. Thanks for your consideration. |
From: Suraj N. K. <sn...@gn...> - 2008-05-31 01:18:14
|
Alan Ezust wrote: > Now it is Alt+Leftarrow to go back a directory. > Please try svn rev# 12733. Thanks, I confirm that Alt+LeftArrow works in r12733. The other command shortcuts (Root dir /, Home dir ~, etc.) are broken still. |
From: Alan E. <ala...@gm...> - 2008-06-04 15:34:08
|
It seems to work for me, as long as the correct component has focus. On Tue, Jun 3, 2008 at 9:14 PM, Suraj N. Kurapati <sn...@gn...> wrote: > Alan Ezust wrote: >> >> I just committed another change to core. > > Thanks, the new shortcuts are much better. > >> Alt+Up now goes to the parent directory. > > One question: in the old LeftArrow implementation, after the directory was > ascended, the previous working directory would be selected (highlighted) in > the tree-menu. So, you could quickly descend back to the directory (from > which you just ascended) by pressing Enter. > > Is this old behavior feasible in the new implementation? > > Thanks for your consideration. > |
From: Suraj N. K. <sn...@gn...> - 2008-05-31 20:11:40
|
Suraj N. Kurapati wrote: > Alan Ezust wrote: >> Now it is Alt+Leftarrow to go back a directory. >> Please try svn rev# 12733. > > Thanks, I confirm that Alt+LeftArrow works in r12733. The other > command shortcuts (Root dir /, Home dir ~, etc.) are broken still. Hmm, the old LeftArrow still works inside a docked File Browser panel, but the new Alt+LeftArrow does not. Would it be possible to retain the old behavior (LeftArrow ascends by one level only)? The reporter of bug 1694133 had a problem where LeftArrow ascended to the root of his file-system, rather than ascending by a single level only. Could we fix the behavior of LeftArrow (I could never reproduce the bug reporter's observations -- maybe he was not using SVN head?) instead of creating a new shortcut (Alt+LeftArrow) for it? Thanks for your consideration. |
From: Alan E. <ala...@gm...> - 2008-06-02 02:09:01
|
I will try to fix the behavior of this dialog, but I have to say, the behavior is very confusing to me. There is a lot of event delegation, and it's not clear how the keystrokes are handled (which widget sees it first) when certain widgets have focus. Combine that with the fact that the "file - open" dialog uses many of the same components as the dockable file system browser, and they share a lot of the same code, but differ in that there is an extra text field that gets initial focus when you are doing file - open. I will take some more looks at this before we release the next version of jEdit, but if someone else wants to take a crack at fixing it too, I'd appreciate it. On Sat, May 31, 2008 at 1:09 PM, Suraj N. Kurapati <sn...@gn...> wrote: > Suraj N. Kurapati wrote: >> >> Alan Ezust wrote: >>> >>> Now it is Alt+Leftarrow to go back a directory. >>> Please try svn rev# 12733. >> >> Thanks, I confirm that Alt+LeftArrow works in r12733. The other >> command shortcuts (Root dir /, Home dir ~, etc.) are broken still. > > Hmm, the old LeftArrow still works inside a docked File Browser panel, but > the new Alt+LeftArrow does not. > > Would it be possible to retain the old behavior (LeftArrow ascends by one > level only)? The reporter of bug 1694133 had a problem where LeftArrow > ascended to the root of his file-system, rather than ascending by a single > level only. > > Could we fix the behavior of LeftArrow (I could never reproduce the bug > reporter's observations -- maybe he was not using SVN head?) instead of > creating a new shortcut (Alt+LeftArrow) for it? > > Thanks for your consideration. > > |
From: Alan E. <ala...@gm...> - 2008-06-03 15:54:10
|
I just committed another change to core. Alt+Up now goes to the parent directory. Alt+Left and Alt+Right go back and forward in the directory stack. I can't figure out why the VFSDirectoryEntryTable never receives the initial keybaord events. it seems when it is a floating dialog, it only gets keyboard events delegated from the VFSFileNameField, and somewhere else in the code, there is some focus-overriding that prevents the directorentrytable from seeing the left and right arrows before they are consumed by the filenamefield. On Sat, May 31, 2008 at 1:09 PM, Suraj N. Kurapati <sn...@gn...> wrote: > Suraj N. Kurapati wrote: >> >> Alan Ezust wrote: >>> >>> Now it is Alt+Leftarrow to go back a directory. >>> Please try svn rev# 12733. >> >> Thanks, I confirm that Alt+LeftArrow works in r12733. The other >> command shortcuts (Root dir /, Home dir ~, etc.) are broken still. > > Hmm, the old LeftArrow still works inside a docked File Browser panel, but > the new Alt+LeftArrow does not. > > Would it be possible to retain the old behavior (LeftArrow ascends by one > level only)? The reporter of bug 1694133 had a problem where LeftArrow > ascended to the root of his file-system, rather than ascending by a single > level only. > > Could we fix the behavior of LeftArrow (I could never reproduce the bug > reporter's observations -- maybe he was not using SVN head?) instead of > creating a new shortcut (Alt+LeftArrow) for it? > > Thanks for your consideration. > > |
From: James <gen...@gm...> - 2008-06-04 13:33:16
|
This works like a CHARM! I just realised how useful the alt-left-arrow functionality is... Nice work, and thanks. On Tue, Jun 3, 2008 at 5:54 PM, Alan Ezust <ala...@gm...> wrote: > I just committed another change to core. > > Alt+Up now goes to the parent directory. > Alt+Left and Alt+Right go back and forward in the directory stack. > I can't figure out why the VFSDirectoryEntryTable never receives the > initial keybaord events. > it seems when it is a floating dialog, it only gets keyboard events > delegated from the > VFSFileNameField, and somewhere else in the code, there is some > focus-overriding that prevents the directorentrytable from seeing the > left and right arrows before they are consumed by the filenamefield. > > > On Sat, May 31, 2008 at 1:09 PM, Suraj N. Kurapati <sn...@gn...> wrote: > > Suraj N. Kurapati wrote: > >> > >> Alan Ezust wrote: > >>> > >>> Now it is Alt+Leftarrow to go back a directory. > >>> Please try svn rev# 12733. > >> > >> Thanks, I confirm that Alt+LeftArrow works in r12733. The other > >> command shortcuts (Root dir /, Home dir ~, etc.) are broken still. > > > > Hmm, the old LeftArrow still works inside a docked File Browser panel, > but > > the new Alt+LeftArrow does not. > > > > Would it be possible to retain the old behavior (LeftArrow ascends by one > > level only)? The reporter of bug 1694133 had a problem where LeftArrow > > ascended to the root of his file-system, rather than ascending by a > single > > level only. > > > > Could we fix the behavior of LeftArrow (I could never reproduce the bug > > reporter's observations -- maybe he was not using SVN head?) instead of > > creating a new shortcut (Alt+LeftArrow) for it? > > > > Thanks for your consideration. > > > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > -- > ----------------------------------------------- > jEdit Users' List > jEd...@li... > https://lists.sourceforge.net/lists/listinfo/jedit-users > |
From: Suraj N. K. <sn...@gn...> - 2008-06-04 04:14:55
|
Alan Ezust wrote: > I just committed another change to core. Thanks, the new shortcuts are much better. > Alt+Up now goes to the parent directory. One question: in the old LeftArrow implementation, after the directory was ascended, the previous working directory would be selected (highlighted) in the tree-menu. So, you could quickly descend back to the directory (from which you just ascended) by pressing Enter. Is this old behavior feasible in the new implementation? Thanks for your consideration. |
From: Suraj N. K. <sn...@gn...> - 2008-06-05 02:36:33
|
Alan Ezust wrote: > It seems to work for me, as long as the correct component has focus. Hmm, I must be doing something wrong then. That was a low benefit feature request anyway: I realized that you could type the first letter of a file name and the File Browser would select (highlight) that node in the tree-menu. That's another approach to solve the problem for me. Thanks for fixing the shortcuts and for your patience with my incessant requests! :-) |
From: Alan E. <ala...@gm...> - 2008-06-05 04:20:50
|
Well, I just fixed another bug, making the initial focus in the dockable FSB now the table instead of the path: text field. now shortcuts will work in the dockable with initial focus. But anyway, when you're reporting that something does not work, I need to know which you are using: dockable (utilities - file system browser) or dialog (file - open), and which component (table, parent directory list, or one of the text fields) has focus when you try shortcuts. update again and let me know what does not work. On Wed, Jun 4, 2008 at 7:36 PM, Suraj N. Kurapati <sn...@gn...> wrote: > Alan Ezust wrote: >> >> It seems to work for me, as long as the correct component has focus. > > Hmm, I must be doing something wrong then. That was a low benefit feature > request anyway: I realized that you could type the first letter of a file > name and the File Browser would select (highlight) that node in the > tree-menu. That's another approach to solve the problem for me. > > Thanks for fixing the shortcuts and for your patience with my incessant > requests! :-) > |