Re: [Jcrbrowser-developers] JCR Browser as an RCP application

[<san...@gm...>]

Hi Ketan,

please see my comments below:

Ketan Padegaonkar wrote:
> Sandro Böhme wrote:
> 
>>Hello Ketan,
>>
>>thank you very much for the contribution of the RCP capabilities! It
>>will add a big benefit to the JCR Browser project. I remember at least
>>one guy who activly asked for this feature. In order to commit and
>>release it I would first like to discuss some things:
> 
> 
> We're actively using JCRBrowser in our project, and having an eclipse
It's nice to read that :-).

> instance running to use a couple of views on a JCR was too expensive. So
> the RCP application.
Right - in case other IDE 's than Eclipse are used the standalone JCR 
Browser not so much resource consuming - I agree.

>>o Are really all plug-ins listed in the JCRBrowser.product file needed?
> 
> 
> I will have to look into the package that I'd sent attached on the
> bugzilla. Most plugins are part of the RCP, and provide for basic
> infrastructure for the application. Are there any other specific plugins
> that you are talking about, which you think should not be needed ?
javax.servlet is probably not needed. I tested it and it worked well 
without it.

> The multiple versions of swt are relevant when I'm exporting the product
> for multiple OSs. I'm right now able to create windows, mac, linux and
> vista versions of JCRBrowser from one product file after installing the
> RCP delta pack.
> See
> http://wbeaton.blogspot.com/2006/04/targetting-different-version-of-rcp.html
> and
> http://wiki.eclipse.org/index.php/RCP_FAQ#What_is_the_recommended_target_platform_setup.3F__Or:_How_can_I_build_and_run_my_RCP_app_against_a_different_version_of_the_Eclipse_base.3F
I will probably be able to test the Mac, Windows and Linux distributions 
during the next weeks with the hardware from colleagues.

>>o Can I simply rename the *.java0000644 files to usual Java files or is
>>there a special reason why they use this naming pattern?
> 
> 
> Oops, I think that there's some issue with the tarball that was attached
> to the bug entry. I'm unable to do a clean untar of the attachment. I'll
> attach another entry to the same bug.
No problem - thanks.

>>o I have no problem with keeping the package name to
>>"com.thoughtworks.jcrbrowser.rcp". I would just prefer to use
>>"org.visualcontent.rcp" if I maintain this module in long term. Please
>>tell me in case you have any interest in maintaining this module and
>>what you think about the package name.
>>o To ensure the users know what license is used please add the Apache2
>>license headers (or a compatible license) to the source files and the
>>license file to the plug-in root folder. I think it would look like
>>hijacking of this plug-in if I would do that ;-). Thanks.
> 
> 
> I'll want to talk to ThoughtWorks on renaming the package names. I do
> not think this should be a problem, since ThoughtWorks has a lot of
> open-source projects.
Sounds good.

> 
> As far as licensing is concerned, I'll add the relevant Apache 2 Headers
> to the source code, in my next attachment to the tarball.
Perfect.

>>o And finally can I do something for you? Like adding a link to your
>>blog or networking tool to the release info containing that feature? It
>>will be published at the Sourceforge project page and in the Jackrabbit
>>mailing list.
> 
> 
> 
> You can add a link to my blog: http://ketan.padegaonkar.name/
I will do that.

I invite you to join the project to be responsible for the RCP version 
of the JCR Browser you created.
The scope of the JCR Browser project is quite small. It's just to 
display the data from as many JCR implementations and deployment models 
as possible and to navigate through them. Editing capabilities are 
planned for my follow up project that I'm currently working on. They are 
out of scope for the JCR Browser. This means the only thing I expect is 
to maintain and support the RCP aspects of the JCR Browser (which you 
seem to handle quite well). If that's ok for you I would be glad if I 
can give you write access to the RCP CVS module of the project and 
welcome you to the JCR Browser project. But anyway, if you don't have 
enough time for that it's still the biggest contribution to this project 
up to now which I appreciate very much.

Thanks,

Sandro

-- 
https://www.xing.com/profile/Sandro_Boehme
http://www.linkedin.com/in/sandroboehme