|
From: Robert E. <sky...@us...> - 2006-04-25 09:28:06
|
Update of /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/bookmarks In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25171/src/org/jcommander/ui/filepanel/bookmarks Modified Files: BookmarkComposite.java BookmarksRootBookmark.java Log Message: Replaced System.out.println and printStackTrace() calls with Log4j logging statements so that every error gets into the log. Index: BookmarksRootBookmark.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/bookmarks/BookmarksRootBookmark.java,v retrieving revision 1.7 retrieving revision 1.8 diff -C2 -d -r1.7 -r1.8 *** BookmarksRootBookmark.java 21 Nov 2005 20:41:06 -0000 1.7 --- BookmarksRootBookmark.java 25 Apr 2006 09:27:58 -0000 1.8 *************** *** 9,12 **** --- 9,13 ---- import org.apache.commons.vfs.*; import org.apache.commons.vfs.impl.*; + import org.apache.log4j.Logger; import org.eclipse.core.runtime.*; import org.jcommander.phileas.bookmarks.*; *************** *** 22,25 **** --- 23,28 ---- public class BookmarksRootBookmark extends Bookmark { + protected static Logger logger = Logger.getLogger(BookmarksRootBookmark.class); + private static final String JCMDBMK_DEFAULT = "/res/jcommander.jcmdbmk.default"; *************** *** 41,46 **** manager.addMimeTypeMap("application/"+BookmarksFileSystem.JCMD_BMK_SCHEME, BookmarksFileSystem.JCMD_BMK_SCHEME); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 44,48 ---- manager.addMimeTypeMap("application/"+BookmarksFileSystem.JCMD_BMK_SCHEME, BookmarksFileSystem.JCMD_BMK_SCHEME); } catch (FileSystemException e) { ! logger.error(e,e); } } *************** *** 75,80 **** } catch (IOException ex) { ! // TODO Auto-generated catch block ! ex.printStackTrace(); } --- 77,81 ---- } catch (IOException ex) { ! logger.error(ex,ex); } Index: BookmarkComposite.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/bookmarks/BookmarkComposite.java,v retrieving revision 1.20 retrieving revision 1.21 diff -C2 -d -r1.20 -r1.21 *** BookmarkComposite.java 30 Dec 2005 14:50:55 -0000 1.20 --- BookmarkComposite.java 25 Apr 2006 09:27:58 -0000 1.21 *************** *** 8,11 **** --- 8,12 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.jface.dialogs.*; import org.eclipse.swt.*; *************** *** 25,28 **** --- 26,32 ---- public class BookmarkComposite extends Composite { + + Logger logger = Logger.getLogger(getClass()); + protected static final String ADD_CURRENT_DIRECTORY_MENU_ENTRY = "Add current directory"; protected static final String EXPAND_MENU_ENTRY = "Expand"; *************** *** 92,97 **** bookmarkPanel.updateBookmarks(bookmarkPanel.getRootBookmark()); } catch (FileSystemException e1) { ! // TODO Auto-generated catch block ! e1.printStackTrace(); } } --- 96,100 ---- bookmarkPanel.updateBookmarks(bookmarkPanel.getRootBookmark()); } catch (FileSystemException e1) { ! logger.error(e1); } } *************** *** 182,186 **** public void handleEvent(Event event) { ! System.out.println("!!!!!mouse button pressed"); } --- 185,189 ---- public void handleEvent(Event event) { ! logger.debug("!!!!!mouse button pressed"); } |