Update of /cvsroot/jcommander/plugins/org.jcommander.ui.musicplayer.contribution/src/org/jcommander/ui/musicplayer/contribution/actions In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25277/src/org/jcommander/ui/musicplayer/contribution/actions Modified Files: ShowPlayer.java AddSelectionToPlaylist.java AddAndPlaySelected.java Log Message: Replaced System.out.println and printStackTrace() calls with Log4j logging statements so that every error gets into the log. Index: AddSelectionToPlaylist.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.musicplayer.contribution/src/org/jcommander/ui/musicplayer/contribution/actions/AddSelectionToPlaylist.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** AddSelectionToPlaylist.java 8 Mar 2006 08:41:16 -0000 1.1 --- AddSelectionToPlaylist.java 25 Apr 2006 09:28:01 -0000 1.2 *************** *** 4,7 **** --- 4,8 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.jface.action.*; import org.eclipse.jface.viewers.*; *************** *** 13,16 **** --- 14,19 ---- public class AddSelectionToPlaylist implements IWorkbenchWindowActionDelegate { + protected Logger logger = Logger.getLogger(getClass()); + private IWorkbenchWindow window; *************** *** 33,38 **** view.addPlaylistItems(selectedFiles); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 36,40 ---- view.addPlaylistItems(selectedFiles); } catch (FileSystemException e) { ! logger.error(e,e); } } Index: ShowPlayer.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.musicplayer.contribution/src/org/jcommander/ui/musicplayer/contribution/actions/ShowPlayer.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** ShowPlayer.java 8 Mar 2006 08:41:16 -0000 1.1 --- ShowPlayer.java 25 Apr 2006 09:28:01 -0000 1.2 *************** *** 1,4 **** --- 1,5 ---- package org.jcommander.ui.musicplayer.contribution.actions; + import org.apache.log4j.Logger; import org.eclipse.jface.action.*; import org.eclipse.jface.viewers.*; *************** *** 9,12 **** --- 10,15 ---- public class ShowPlayer implements IWorkbenchWindowActionDelegate { + protected Logger logger = Logger.getLogger(getClass()); + private IWorkbenchWindow window; *************** *** 27,32 **** MusicplayerPlugin.getDefault().setMusicPlayerView(view); } catch (PartInitException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 30,34 ---- MusicplayerPlugin.getDefault().setMusicPlayerView(view); } catch (PartInitException e) { ! logger.error(e,e); } } Index: AddAndPlaySelected.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.musicplayer.contribution/src/org/jcommander/ui/musicplayer/contribution/actions/AddAndPlaySelected.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** AddAndPlaySelected.java 9 Mar 2006 12:35:10 -0000 1.1 --- AddAndPlaySelected.java 25 Apr 2006 09:28:01 -0000 1.2 *************** *** 4,7 **** --- 4,8 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.jface.action.*; import org.eclipse.jface.viewers.*; *************** *** 13,16 **** --- 14,19 ---- public class AddAndPlaySelected implements IWorkbenchWindowActionDelegate { + protected Logger logger = Logger.getLogger(getClass()); + private IWorkbenchWindow window; *************** *** 33,38 **** view.addPlaylistItems(selectedFiles); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 36,40 ---- view.addPlaylistItems(selectedFiles); } catch (FileSystemException e) { ! logger.error(e,e); } } |