|
From: Robert E. <sky...@us...> - 2006-04-25 09:28:05
|
Update of /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/actions In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25171/src/org/jcommander/ui/filepanel/actions Modified Files: SwitchToTreeAction.java ComputeDirectorySizeAction.java CopyToClipboard.java ComputeAllDirectorySizesAction.java SwitchToDirectoryAction.java Log Message: Replaced System.out.println and printStackTrace() calls with Log4j logging statements so that every error gets into the log. Index: SwitchToDirectoryAction.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/actions/SwitchToDirectoryAction.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** SwitchToDirectoryAction.java 9 Jan 2006 01:08:32 -0000 1.1 --- SwitchToDirectoryAction.java 25 Apr 2006 09:27:58 -0000 1.2 *************** *** 1,4 **** --- 1,5 ---- package org.jcommander.ui.filepanel.actions; + import org.apache.log4j.Logger; import org.eclipse.jface.action.IAction; import org.eclipse.jface.viewers.ISelection; *************** *** 10,13 **** --- 11,16 ---- public class SwitchToDirectoryAction implements IWorkbenchWindowActionDelegate { + Logger logger = Logger.getLogger(getClass()); + public void dispose() { // TODO Auto-generated method stub *************** *** 21,25 **** public void run(IAction action) { ! System.out.println("switch to directory action"); TabMediator activeTabMediator = FilePanelManagerProvider.getTabManager() .getActiveTabMediator(); --- 24,28 ---- public void run(IAction action) { ! logger.debug("switch to directory action"); TabMediator activeTabMediator = FilePanelManagerProvider.getTabManager() .getActiveTabMediator(); Index: CopyToClipboard.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/actions/CopyToClipboard.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** CopyToClipboard.java 1 Jan 2006 22:26:27 -0000 1.1 --- CopyToClipboard.java 25 Apr 2006 09:27:58 -0000 1.2 *************** *** 5,8 **** --- 5,9 ---- import org.apache.commons.vfs.*; import org.apache.commons.vfs.provider.local.*; + import org.apache.log4j.Logger; import org.eclipse.jface.action.*; import org.eclipse.jface.viewers.*; *************** *** 16,19 **** --- 17,22 ---- public class CopyToClipboard implements IWorkbenchWindowActionDelegate { + protected Logger logger = Logger.getLogger(getClass()); + private IWorkbenchWindow window; *************** *** 54,59 **** } } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } --- 57,61 ---- } } catch (FileSystemException e) { ! logger.error(e,e); } Index: ComputeAllDirectorySizesAction.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/actions/ComputeAllDirectorySizesAction.java,v retrieving revision 1.2 retrieving revision 1.3 diff -C2 -d -r1.2 -r1.3 *** ComputeAllDirectorySizesAction.java 28 Dec 2005 11:34:05 -0000 1.2 --- ComputeAllDirectorySizesAction.java 25 Apr 2006 09:27:58 -0000 1.3 *************** *** 2,5 **** --- 2,6 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.core.runtime.*; import org.eclipse.core.runtime.jobs.*; *************** *** 15,18 **** --- 16,21 ---- IWorkbenchWindowActionDelegate { + protected Logger logger = Logger.getLogger(getClass()); + public void dispose() { // TODO Auto-generated method stub *************** *** 57,62 **** return Status.OK_STATUS; } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); return Status.CANCEL_STATUS; --- 60,64 ---- return Status.OK_STATUS; } catch (FileSystemException e) { ! logger.error(e,e); return Status.CANCEL_STATUS; *************** *** 75,80 **** fileControlModel.getControl().doRefresh(); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 77,81 ---- fileControlModel.getControl().doRefresh(); } catch (FileSystemException e) { ! logger.error(e,e); } } *************** *** 85,90 **** job.schedule(); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 86,90 ---- job.schedule(); } catch (FileSystemException e) { ! logger.error(e,e); } } Index: ComputeDirectorySizeAction.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/actions/ComputeDirectorySizeAction.java,v retrieving revision 1.4 retrieving revision 1.5 diff -C2 -d -r1.4 -r1.5 *** ComputeDirectorySizeAction.java 20 Jan 2006 14:17:26 -0000 1.4 --- ComputeDirectorySizeAction.java 25 Apr 2006 09:27:58 -0000 1.5 *************** *** 4,7 **** --- 4,8 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.core.runtime.*; import org.eclipse.core.runtime.jobs.*; *************** *** 17,20 **** --- 18,23 ---- IWorkbenchWindowActionDelegate { + protected static Logger logger = Logger.getLogger(ComputeDirectorySizeAction.class); + public void dispose() { // TODO Auto-generated method stub *************** *** 72,77 **** fileControlModel.getControl().doRefresh(); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 75,79 ---- fileControlModel.getControl().doRefresh(); } catch (FileSystemException e) { ! logger.error(e,e); } } *************** *** 98,103 **** } } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 100,104 ---- } } catch (FileSystemException e) { ! logger.error(e,e); } } Index: SwitchToTreeAction.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/actions/SwitchToTreeAction.java,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** SwitchToTreeAction.java 9 Jan 2006 01:08:32 -0000 1.1 --- SwitchToTreeAction.java 25 Apr 2006 09:27:58 -0000 1.2 *************** *** 1,4 **** --- 1,5 ---- package org.jcommander.ui.filepanel.actions; + import org.apache.log4j.Logger; import org.eclipse.jface.action.IAction; import org.eclipse.jface.viewers.ISelection; *************** *** 15,18 **** --- 16,21 ---- public class SwitchToTreeAction implements IWorkbenchWindowActionDelegate { + Logger logger = Logger.getLogger(getClass()); + public void dispose() { // TODO Auto-generated method stub *************** *** 27,31 **** public void run(IAction action) { ! System.out.println("switch to tree action"); TabMediator activeTabMediator = FilePanelManagerProvider.getTabManager() .getActiveTabMediator(); --- 30,34 ---- public void run(IAction action) { ! logger.debug("switch to tree action"); TabMediator activeTabMediator = FilePanelManagerProvider.getTabManager() .getActiveTabMediator(); |