|
From: Robert E. <sky...@us...> - 2006-04-25 09:28:05
|
Update of /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/model In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25171/src/org/jcommander/ui/filepanel/model Modified Files: FileControlModel.java Log Message: Replaced System.out.println and printStackTrace() calls with Log4j logging statements so that every error gets into the log. Index: FileControlModel.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/model/FileControlModel.java,v retrieving revision 1.55 retrieving revision 1.56 diff -C2 -d -r1.55 -r1.56 *** FileControlModel.java 23 Mar 2006 02:55:32 -0000 1.55 --- FileControlModel.java 25 Apr 2006 09:27:58 -0000 1.56 *************** *** 11,14 **** --- 11,15 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.jface.resource.*; import org.eclipse.jface.viewers.deferred.*; *************** *** 27,30 **** --- 28,34 ---- */ public class FileControlModel extends SetModel{ + + Logger logger = Logger.getLogger(getClass()); + private static final FileObject[] NULL_FILES = {}; *************** *** 224,228 **** catch(Exception e) { //ignore ! System.out.println("no item " + index + " in the table"); } } --- 228,232 ---- catch(Exception e) { //ignore ! logger.error("no item " + index + " in the table: " + e.getMessage()); } } *************** *** 722,727 **** } } catch (FileSystemException ex) { ! // TODO Do proper error reporting ! ex.printStackTrace(); } } --- 726,730 ---- } } catch (FileSystemException ex) { ! logger.error(ex,ex); } } *************** *** 778,782 **** } catch(Exception e) { ! System.out.println("no such element"); return null; } --- 781,785 ---- } catch(Exception e) { ! logger.error("no such element: " + e.getMessage()); return null; } *************** *** 845,850 **** control.selectNone(); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } --- 848,852 ---- control.selectNone(); } catch (FileSystemException e) { ! logger.error(e,e); } *************** *** 858,863 **** control.setMarkedFiles(files); } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 860,864 ---- control.setMarkedFiles(files); } catch (FileSystemException e) { ! logger.error(e,e); } } |