Menu
▾
▴
[Jcommander-commit] plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls FilePanel.java,1.61,1.62 FilePanelMediator.java,1.48,1.49 DirectoryTreeManager.java,1.9,1.10 FileTableControl.java,1.88,1.89 FileTab.java,1.40,1.41
Update of /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25171/src/org/jcommander/ui/filepanel/controls Modified Files: FilePanel.java FilePanelMediator.java DirectoryTreeManager.java FileTableControl.java FileTab.java Log Message: Replaced System.out.println and printStackTrace() calls with Log4j logging statements so that every error gets into the log. Index: FilePanelMediator.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls/FilePanelMediator.java,v retrieving revision 1.48 retrieving revision 1.49 diff -C2 -d -r1.48 -r1.49 *** FilePanelMediator.java 5 Apr 2006 20:34:31 -0000 1.48 --- FilePanelMediator.java 25 Apr 2006 09:27:57 -0000 1.49 *************** *** 288,293 **** public void inPlaceRename() { - //System.out.println("HERE!: " + fileControl.viewer.getSelection()); - //fileControl.viewer.editElement(fileControl.viewer.getSelection(), 1); // TODO Implement this as a cell editor! --- 288,291 ---- Index: DirectoryTreeManager.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls/DirectoryTreeManager.java,v retrieving revision 1.9 retrieving revision 1.10 diff -C2 -d -r1.9 -r1.10 *** DirectoryTreeManager.java 5 Apr 2006 20:57:01 -0000 1.9 --- DirectoryTreeManager.java 25 Apr 2006 09:27:57 -0000 1.10 *************** *** 4,7 **** --- 4,8 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.swt.*; import org.eclipse.swt.events.*; *************** *** 20,23 **** --- 21,26 ---- public class DirectoryTreeManager { + protected Logger logger = Logger.getLogger(getClass()); + private static final String DUMMY_ITEM_TEXT = ""; private Tree directoryTree; *************** *** 69,74 **** } } catch (FileSystemException e) { ! // TODO Auto-generated catch block ! e.printStackTrace(); } } --- 72,76 ---- } } catch (FileSystemException e) { ! logger.error(e,e); } } *************** *** 178,183 **** } } catch (FileSystemException e1) { ! // TODO Auto-generated catch block ! e1.printStackTrace(); } --- 180,184 ---- } } catch (FileSystemException e1) { ! logger.error(e1); } Index: FileTableControl.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls/FileTableControl.java,v retrieving revision 1.88 retrieving revision 1.89 diff -C2 -d -r1.88 -r1.89 *** FileTableControl.java 26 Mar 2006 13:02:32 -0000 1.88 --- FileTableControl.java 25 Apr 2006 09:27:57 -0000 1.89 *************** *** 7,10 **** --- 7,11 ---- import org.apache.commons.vfs.*; + import org.apache.log4j.Logger; import org.eclipse.core.runtime.*; import org.eclipse.core.runtime.jobs.*; *************** *** 36,39 **** --- 37,43 ---- */ public class FileTableControl { + + Logger logger = Logger.getLogger(getClass()); + protected Shell shell; *************** *** 268,272 **** // // public void modify(Object element, String property, Object value) { ! // System.out.println("Trying to modify"); // } // --- 272,276 ---- // // public void modify(Object element, String property, Object value) { ! // logger.debug("Trying to modify"); // } // *************** *** 274,278 **** // FileDetails details = (FileDetails)element; // ! // System.out.println("property = " + property); // // return details.getDetails()[1]; --- 278,282 ---- // FileDetails details = (FileDetails)element; // ! // logger.debug("property = " + property); // // return details.getDetails()[1]; *************** *** 310,314 **** } catch(Exception ex) { ! ex.printStackTrace(); } } --- 314,318 ---- } catch(Exception ex) { ! logger.error(ex); } } *************** *** 365,369 **** } catch(FileSystemException ex) { ! ex.printStackTrace(); } } --- 369,373 ---- } catch(FileSystemException ex) { ! logger.error(ex); } } *************** *** 618,622 **** } catch (FileSystemException ex) { LoggerPlugin.getLogger(this.getClass()).error(ex,ex); - ex.printStackTrace(); } --- 622,625 ---- Index: FilePanel.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls/FilePanel.java,v retrieving revision 1.61 retrieving revision 1.62 diff -C2 -d -r1.61 -r1.62 *** FilePanel.java 5 Apr 2006 20:34:31 -0000 1.61 --- FilePanel.java 25 Apr 2006 09:27:57 -0000 1.62 *************** *** 6,9 **** --- 6,10 ---- import org.apache.commons.vfs.*; import org.apache.commons.vfs.provider.local.*; + import org.apache.log4j.Logger; import org.eclipse.jface.bindings.*; import org.eclipse.jface.resource.*; *************** *** 31,34 **** --- 32,37 ---- public class FilePanel extends Composite { + Logger logger = Logger.getLogger(getClass()); + private Composite partitionComposite = null; private Label partitionInfoLabel = null; *************** *** 123,128 **** fileControl.toggleSelectCurrentFile(false); } catch (FileSystemException e1) { ! // TODO Auto-generated catch block ! e1.printStackTrace(); } } --- 126,130 ---- fileControl.toggleSelectCurrentFile(false); } catch (FileSystemException e1) { ! logger.error(e1); } } *************** *** 737,741 **** public void switchToTree() { ! System.out.println("switch to tree"); if(sashForm.getMaximizedControl() == null) directoryTree.setFocus(); --- 739,743 ---- public void switchToTree() { ! logger.debug("switch to tree"); if(sashForm.getMaximizedControl() == null) directoryTree.setFocus(); Index: FileTab.java =================================================================== RCS file: /cvsroot/jcommander/plugins/org.jcommander.ui.filepanel/src/org/jcommander/ui/filepanel/controls/FileTab.java,v retrieving revision 1.40 retrieving revision 1.41 diff -C2 -d -r1.40 -r1.41 *** FileTab.java 8 Jan 2006 12:43:44 -0000 1.40 --- FileTab.java 25 Apr 2006 09:27:57 -0000 1.41 *************** *** 7,10 **** --- 7,11 ---- import org.apache.commons.vfs.FileObject; + import org.apache.log4j.Logger; import org.eclipse.jface.preference.*; import org.eclipse.jface.resource.*; *************** *** 26,29 **** --- 27,32 ---- public class FileTab extends Composite { + protected Logger logger = Logger.getLogger(getClass()); + private SashForm bookmarkPanelsComposite = null; private Composite filePanelsComposite = null; *************** *** 371,375 **** } catch(Exception ex){ ! ex.printStackTrace(); } panel.getFileControl().setCurrentSelection(-1); --- 374,378 ---- } catch(Exception ex){ ! logger.error(ex); } panel.getFileControl().setCurrentSelection(-1); |
