When displaying VFS URLs in the user interface try to
make them safe (no passwords!) and more user friendly.
For instance, the current directory in the file panel
should not display the file:// prefix for local files
because this is redundant. Under Windows, local paths
should look like c:\Program Files\ rather than
file://c:/Program Files/.
Logged In: YES
user_id=1473670
I like the way filenames are displayed now. For local files
a complete VFS URL has too much overhead. Not displaying
passwords is great too, because that was an serious reason
against using JCommander with SFTP etc. Probably we should
extend this behaviour to the bookmark panel also.
Logged In: YES
user_id=940779
Actually this should rather be a feature of Commons VFS.
When VFS 1.0 will be released I will make a submission to
them with what code we can contribute. I agree that this
feature can be extended to the bookmark manager easily.
Regarding passwords, right now a major problem of VFS is
that there isn't a callback mechanism for authentication. So
you either send the correct user name and password or your
connection will be refused without a verbose exception. This
will hopefully be dealth with in VFS 1.1
Logged In: YES
user_id=1473670
Now the compare view and the copy/move confirm dialog are
updated to use the displayable path, too. I am currently
thinking about providing an alternative to File/Open
Directory URL for FTP/SFTP, which would be a dialog in which
one could enter username, password, host and directory apart
from each other, and the password of course unreadable. Then
one could use SFTP without seeing the password at all. I
think this could be a workaround until the callback
mechanism is implemented.
Logged In: YES
user_id=940779
Matthias, this is definitely a good idea. Please also take a
look at this forum discussion:
https://sourceforge.net/forum/message.php?msg_id=3647883
In case you decide to go ahead with the dialog I would
suggest to you to create a feature request so that we can
move the related discussions there.
Logged In: YES
user_id=1473670
I am currently working on the proposed feature and am going
to create the feature request the next days. While working
on this, a question occured to me: Did you ever think about
using the JFace dialogs? E.g. TitleAreaDialog provides a
nice and quite useable dialog. I am using it currently for
the proposed dialog. But I can change it easily if there is
a reason for not using it.
I also took a look at the forum thread you noticed. The
possibility to open help in the DialogTray looks very
interesting. I investigated this and at least managed to
open the correct help page by hitting "F1". But I did not
manage to open this help page in the DialogTray, instead the
context menu popped up and the help opened in a new window.
Logged In: YES
user_id=940779
Great idea! Actually I wasn't familiar with JFace dialogs
not having used them before. However, a quick look on the
API cleared thigs up and we should definitely use them. The
TitleAreaDialog is very handy since its able to display
icons, messages and error messages, looks more professional
and is familiar to Eclipse users. So please feel free to go
ahead and use it and after that we should investigate how to
make use of it for the rest of the dialogs.
I think that you might find something related to how to
display the help view inside the dialog by looking to the
Help preference page in Eclipse. There's a property called
"Open dialog context help" which in my installation is set
to "in dialog tray". Maybe that's a property that is used
and which in JCommander is not set.