jcl-checkins-diff Mailing List for JEDI Code Library (Page 14)

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Revision: 3567
          http://jcl.svn.sourceforge.net/jcl/?rev=3567&view=rev
Author:   outchy
Date:     2011-08-10 15:44:44 +0000 (Wed, 10 Aug 2011)

Log Message:
-----------
removal of the with..do statements.

Modified Paths:
--------------
    trunk/jcl/source/windows/JclAppInst.pas

Modified: trunk/jcl/source/windows/JclAppInst.pas
===================================================================

--- trunk/jcl/source/windows/JclAppInst.pas	2011-08-08 17:49:53 UTC (rev 3566)
+++ trunk/jcl/source/windows/JclAppInst.pas	2011-08-10 15:44:44 UTC (rev 3567)
@@ -208,17 +208,17 @@
 end;
 
 function TJclAppInstances.CheckInstance(const MaxInstances: Word): Boolean;
+var
+  SharedData: PJclAISharedData;
 begin
   FOptex.Enter;
   try
-    with PJclAISharedData(FMappingView.Memory)^ do
-    begin
-      if MaxInst = 0 then
-        MaxInst := MaxInstances;
-      Result := Count < MaxInst;
-      ProcessIDs[Count] := GetCurrentProcessId;
-      Inc(Count);
-    end;
+    SharedData := PJclAISharedData(FMappingView.Memory);
+    if SharedData^.MaxInst = 0 then
+      SharedData^.MaxInst := MaxInstances;
+    Result := SharedData^.Count < SharedData^.MaxInst;
+    SharedData^.ProcessIDs[SharedData^.Count] := GetCurrentProcessId;
+    Inc(SharedData^.Count);
   finally
     FOptex.Leave;
   end;
@@ -292,33 +292,34 @@
 function TJclAppInstances.GetInstanceIndex(ProcessID: DWORD): Integer;
 var
   I: Integer;
+  SharedData: PJclAISharedData;
 begin
   Result := -1;
   FOptex.Enter;
   try
-    with PJclAISharedData(FMappingView.Memory)^ do
-    begin
-      for I := 0 to Count - 1 do
-        if ProcessIDs[I] = ProcessID then
-        begin
-          Result := I;
-          Break;
-        end;
-    end;
+    SharedData := PJclAISharedData(FMappingView.Memory);
+    for I := 0 to SharedData^.Count - 1 do
+      if SharedData^.ProcessIDs[I] = ProcessID then
+      begin
+        Result := I;
+        Break;
+      end;
   finally
     FOptex.Leave;
   end;
 end;
 
 function TJclAppInstances.GetProcessIDs(Index: Integer): DWORD;
+var
+  SharedData: PJclAISharedData;
 begin
   FOptex.Enter;
   try
-    with PJclAISharedData(FMappingView.Memory)^ do
-      if Index >= Count then
-        Result := 0
-      else
-        Result := ProcessIDs[Index];
+    SharedData := PJclAISharedData(FMappingView.Memory);
+    if Index >= SharedData^.Count then
+      Result := 0
+    else
+      Result := SharedData^.ProcessIDs[Index];
   finally
     FOptex.Leave;
   end;
@@ -354,8 +355,7 @@
 
 function EnumNotifyWinProc(Wnd: THandle; Message: PMessage): BOOL; stdcall;
 begin
-  with Message^ do
-    SendNotifyMessage(Wnd, Msg, WParam, LParam);
+  SendNotifyMessage(Wnd, Message^.Msg, Message^.WParam, Message^.LParam);
   Result := True;
 end;
 
@@ -365,26 +365,27 @@
   Wnd: THandle;
   TID: DWORD;
   Msg: TMessage;
+  SharedData: PJclAISharedData;
 begin
   FOptex.Enter;
   try
-    with PJclAISharedData(FMappingView.Memory)^ do
-      for I := 0 to Count - 1 do
-      begin
-        Wnd := GetApplicationWnd(ProcessIDs[I]);
-        TID := GetWindowThreadProcessId(Wnd, nil);
-        while Wnd <> 0 do
-        begin // Send message to TApplication queue
-          if PostThreadMessage(TID, FMessageID, W, L) or
-            (GetLastError = ERROR_INVALID_THREAD_ID) then
-            Break;
-          Sleep(1);
-        end;
-        Msg.Msg := FMessageID;
-        Msg.WParam := W;
-        Msg.LParam := L;
-        EnumThreadWindows(TID, @EnumNotifyWinProc, LPARAM(@Msg));
+    SharedData := PJclAISharedData(FMappingView.Memory);
+    for I := 0 to SharedData^.Count - 1 do
+    begin
+      Wnd := GetApplicationWnd(SharedData^.ProcessIDs[I]);
+      TID := GetWindowThreadProcessId(Wnd, nil);
+      while Wnd <> 0 do
+      begin // Send message to TApplication queue
+        if PostThreadMessage(TID, FMessageID, W, L) or
+          (GetLastError = ERROR_INVALID_THREAD_ID) then
+          Break;
+        Sleep(1);
       end;
+      Msg.Msg := FMessageID;
+      Msg.WParam := W;
+      Msg.LParam := L;
+      EnumThreadWindows(TID, @EnumNotifyWinProc, LPARAM(@Msg));
+    end;
   finally
     FOptex.Leave;
   end;
@@ -393,18 +394,19 @@
 procedure TJclAppInstances.RemoveInstance;
 var
   I: Integer;
+  SharedData: PJclAISharedData;
 begin
   FOptex.Enter;
   try
-    with PJclAISharedData(FMappingView.Memory)^ do
-      for I := 0 to Count - 1 do
-        if ProcessIDs[I] = FCPID then
-        begin
-          ProcessIDs[I] := 0;
-          Move(ProcessIDs[I + 1], ProcessIDs[I], (Count - I) * SizeOf(DWORD));
-          Dec(Count);
-          Break;
-        end;
+    SharedData := PJclAISharedData(FMappingView.Memory);
+    for I := 0 to SharedData^.Count - 1 do
+      if SharedData^.ProcessIDs[I] = FCPID then
+      begin
+        SharedData^.ProcessIDs[I] := 0;
+        Move(SharedData^.ProcessIDs[I + 1], SharedData^.ProcessIDs[I], (SharedData^.Count - I) * SizeOf(DWORD));
+        Dec(SharedData^.Count);
+        Break;
+      end;
   finally
     FOptex.Leave;
   end;
@@ -441,6 +443,7 @@
   I: Integer;
   PID: DWORD;
   Found: Boolean;
+  SharedData: PJclAISharedData;
 begin
   if (GetClassName(Wnd, ClassName, Length(ClassName) - 1) > 0) and
     (StrComp(ClassName, Data.WindowClassName) = 0) then
@@ -449,13 +452,13 @@
     Found := False;
     Data.Self.FOptex.Enter;
     try
-      with PJclAISharedData(Data.Self.FMappingView.Memory)^ do
-        for I := 0 to Count - 1 do
-          if ProcessIDs[I] = PID then
-          begin
-            Found := True;
-            Break;
-          end;
+      SharedData := PJclAISharedData(Data.Self.FMappingView.Memory);
+      for I := 0 to SharedData^.Count - 1 do
+        if SharedData^.ProcessIDs[I] = PID then
+        begin
+          Found := True;
+          Break;
+        end;
     finally
       Data.Self.FOptex.Leave;
     end;
@@ -560,32 +563,29 @@
 
 procedure ReadMessageData(const Message: TMessage; var Data: Pointer; var Size: Integer);
 begin
-  with TWMCopyData(Message) do
-    if Msg = WM_COPYDATA then
-    begin
-      Size := CopyDataStruct^.cbData;
-      GetMem(Data, Size);
-      Move(CopyDataStruct^.lpData^, Data^, Size);
-    end;
+  if TWMCopyData(Message).Msg = WM_COPYDATA then
+  begin
+    Size := TWMCopyData(Message).CopyDataStruct^.cbData;
+    GetMem(Data, Size);
+    Move(TWMCopyData(Message).CopyDataStruct^.lpData^, Data^, Size);
+  end;
 end;
 
 procedure ReadMessageString(const Message: TMessage; out S: string);
 begin
-  with TWMCopyData(Message) do
-    if Msg = WM_COPYDATA then
-      SetString(S, PChar(CopyDataStruct^.lpData), CopyDataStruct^.cbData div SizeOf(Char));
+  if TWMCopyData(Message).Msg = WM_COPYDATA then
+    SetString(S, PChar(TWMCopyData(Message).CopyDataStruct^.lpData), TWMCopyData(Message).CopyDataStruct^.cbData div SizeOf(Char));
 end;
 
 procedure ReadMessageStrings(const Message: TMessage; const Strings: TStrings);
 var
   S: string;
 begin
-  with TWMCopyData(Message) do
-    if Msg = WM_COPYDATA then
-    begin
-      ReadMessageString(Message, S);
-      Strings.Text := S;
-    end;
+  if TWMCopyData(Message).Msg = WM_COPYDATA then
+  begin
+    ReadMessageString(Message, S);
+    Strings.Text := S;
+  end;
 end;
 
 function SendData(const Wnd, OriginatorWnd: HWND;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.




2006	Jan	Feb	Mar	Apr (20)	May (48)	Jun (8)	Jul (23)	Aug (41)	Sep (42)	Oct (22)	Nov (17)	Dec (36)
2007	Jan (43)	Feb (42)	Mar (17)	Apr (39)	May (16)	Jun (35)	Jul (37)	Aug (47)	Sep (49)	Oct (9)	Nov (52)	Dec (37)
2008	Jan (48)	Feb (21)	Mar (7)	Apr (2)	May (5)	Jun (17)	Jul (17)	Aug (40)	Sep (58)	Oct (38)	Nov (19)	Dec (32)
2009	Jan (67)	Feb (46)	Mar (54)	Apr (34)	May (37)	Jun (52)	Jul (67)	Aug (72)	Sep (48)	Oct (35)	Nov (27)	Dec (12)
2010	Jan (56)	Feb (46)	Mar (19)	Apr (14)	May (21)	Jun (3)	Jul (13)	Aug (48)	Sep (34)	Oct (51)	Nov (16)	Dec (32)
2011	Jan (36)	Feb (14)	Mar (12)	Apr (3)	May (5)	Jun (24)	Jul (15)	Aug (30)	Sep (21)	Oct (4)	Nov (25)	Dec (23)
2012	Jan (45)	Feb (42)	Mar (19)	Apr (14)	May (13)	Jun (7)	Jul (3)	Aug (46)	Sep (21)	Oct (10)	Nov (2)	Dec
2013	Jan (5)	Feb	Mar	Apr	May	Jun	Jul	Aug	Sep	Oct	Nov	Dec

jcl-checkins-diff Mailing List for JEDI Code Library (Page 14)

jcl-checkins-diff — SVN file check-in notifications with file differences included