#149 ObjectPool race conditions + config fix

[Quentin Conner]

See
http://sourceforge.net/mailarchive/forum.php?thread_id=442419&forum_id=7101
for some background info.

This patch fixes race conditions in ObjectPool (someone
recently submitted similar patches but our snapshot was
from 2.4.4 release) and related problems with Minerva
pool configuration (silently ignored and missing
parameters).

Still remaining is the root cause that led me to fix
ObjectPool. Periodically the JDBC connection managed
by the EJB container's transaction manager (these are
local and non-XA transactions) "leaks" a JDBC
connection. In other words a conn =
Datasource.getConnection() is followed by a
conn.close(), but the corresponding ConnectionInPool
object doesn't get returned to the pool. This happens
predictably.

Also still remaining to fix is that trailing whitespace
on certain Minerva config parameters causes them to be
silently ignored e.g. GCMinIdleTime.

The patch is against Branch_2_4 as of tonight for the
jboss-all module. Note that I had some trouble with
(new) create-manifest targets in Ant. Perhaps the ant
classes are old?

Quentin
quentin@qns.net

[Quentin Conner]

univ diff

[Quentin Conner]

Logged In: YES
user_id=445536

probably fixes bug #476565 and #478882

[Christian Riege]

Logged In: YES
user_id=176671

applied to CVS tree with some minor modifications