[Jboss-svn-commits] JBL Code SVN: r3720 - in labs/jbossrules/trunk/drools-core/src: main/java/org/drools/base test/java/org/drools/base

[<jbo...@li...>]

Author: tirelli
Date: 2006-04-14 17:32:03 -0400 (Fri, 14 Apr 2006)
New Revision: 3720

Added:
   labs/jbossrules/trunk/drools-core/src/test/java/org/drools/base/FieldImplTest.java
Modified:
   labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/FieldImpl.java
Log:
JBRULES-213: fixing node sharing problem when field was null

Modified: labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/FieldImpl.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/FieldImpl.java	2006-04-14 21:10:20 UTC (rev 3719)
+++ labs/jbossrules/trunk/drools-core/src/main/java/org/drools/base/FieldImpl.java	2006-04-14 21:32:03 UTC (rev 3720)
@@ -33,7 +33,7 @@
         if (this.value != null) {
             return this.value.hashCode();
         } else {
-            return super.hashCode();
+            return 0;
         }
     }
 }
\ No newline at end of file

Added: labs/jbossrules/trunk/drools-core/src/test/java/org/drools/base/FieldImplTest.java
===================================================================
--- labs/jbossrules/trunk/drools-core/src/test/java/org/drools/base/FieldImplTest.java	2006-04-14 21:10:20 UTC (rev 3719)
+++ labs/jbossrules/trunk/drools-core/src/test/java/org/drools/base/FieldImplTest.java	2006-04-14 21:32:03 UTC (rev 3720)
@@ -0,0 +1,54 @@
+package org.drools.base;
+
+import junit.framework.Assert;
+import junit.framework.TestCase;
+
+public class FieldImplTest extends TestCase {
+    FieldImpl field1;
+    FieldImpl field2;
+    FieldImpl field3;
+    FieldImpl field4;
+    FieldImpl field5;
+
+    protected void setUp() throws Exception {
+        super.setUp();
+        this.field1 = new FieldImpl(null);
+        this.field2 = new FieldImpl(null);
+        this.field3 = new FieldImpl("A");
+        this.field4 = new FieldImpl("A");
+        this.field5 = new FieldImpl("B");
+        
+    }
+
+    protected void tearDown() throws Exception {
+        super.tearDown();
+        Assert.assertEquals( field1, field1 );
+        Assert.assertEquals( field1, field2 );
+        Assert.assertEquals( field3, field3 );
+        Assert.assertEquals( field3, field4 );
+        Assert.assertFalse( field1.equals( field3 ) );
+        Assert.assertFalse( field3.equals( field1 ) );
+        Assert.assertFalse( field3.equals( field5 ) );
+    }
+
+    /*
+     * Test method for 'org.drools.base.FieldImpl.hashCode()'
+     */
+    public void testHashCode() {
+        Assert.assertEquals( field1.hashCode(), field1.hashCode() );
+        Assert.assertEquals( field1.hashCode(), field2.hashCode() );
+        Assert.assertEquals( field3.hashCode(), field3.hashCode() );
+        Assert.assertEquals( field3.hashCode(), field4.hashCode() );
+        Assert.assertFalse( field1.hashCode() == field3.hashCode() );
+        Assert.assertFalse( field3.hashCode() == field1.hashCode() );
+        Assert.assertFalse( field3.hashCode() == field5.hashCode() );
+    }
+
+    /*
+     * Test method for 'org.drools.base.FieldImpl.equals(Object)'
+     */
+    public void testEqualsObject() {
+
+    }
+
+}