Menu
▾
▴
[Jboss-svn-commits] JBL Code SVN: r1148 - trunk/labs/kosmos/src/java/hu/midori/kosmos/server/jira
|
From: <jbo...@li...> - 2005-09-19 08:50:25
|
Author: aron.gombas
Date: 2005-09-19 04:50:20 -0400 (Mon, 19 Sep 2005)
New Revision: 1148
Modified:
trunk/labs/kosmos/src/java/hu/midori/kosmos/server/jira/JiraServiceImpl.java
Log:
Cleanup
Modified: trunk/labs/kosmos/src/java/hu/midori/kosmos/server/jira/JiraServiceImpl.java
===================================================================
--- trunk/labs/kosmos/src/java/hu/midori/kosmos/server/jira/JiraServiceImpl.java 2005-09-19 08:29:09 UTC (rev 1147)
+++ trunk/labs/kosmos/src/java/hu/midori/kosmos/server/jira/JiraServiceImpl.java 2005-09-19 08:50:20 UTC (rev 1148)
@@ -82,7 +82,7 @@
try {
Document dom = ScrapingUtils.downloadHtmlDom(new URL(url));
- //!!! EZEKET A QUERY-KET UJRA MEGNEZ
+ // TODO review these queries
// run XQueries
String queryProject =
"for " +
@@ -94,7 +94,7 @@
"{ data(fn:substring-after(fn:normalize-space($d/child::tr/child::td/child::h3/text()), ' ')) }|" +
"{ data(fn:substring-after(fn:substring-before($d/child::tr/child::td/child::h3/font/text(), ')'), ' ')) }|" +
"{ data($d/following-sibling::table/child::tr/child::td/child::p[1]/child::a[2]) }|" +
- "{ data(fn:normalize-space(fn:string-join($d/following-sibling::table/child::tr/child::td/child::p[1]/text(), ''))) }|" +//!!! SPACE-EKET TRIMMEL
+ "{ data(fn:normalize-space(fn:string-join($d/following-sibling::table/child::tr/child::td/child::p[1]/text(), ''))) }|" +
"{ data($d/following-sibling::table/child::tr/child::td/child::p[1]/child::a[1]) }" +
"</dummy>";
List resultProject = ScrapingUtils.runXQuery(dom, queryProject);
@@ -107,10 +107,10 @@
"where " +
"count($d/child::td) = 4 and " +
"contains($d/child::td[2]/child::a[1]/@href, '/secure/IssueNavigator.jspa') and " +
- "contains($d/child::td[2]/child::a[1]/@href, 'status') " + // can be "status" or "statusIds"
+ "contains($d/child::td[2]/child::a[1]/@href, 'status') " + // can be "status" or "statusIds"
"return " +
"<dummy>" +
- "{ data(fn:substring-after(fn:substring-after($d/child::td[2]/child::a[1]/@href, 'status'), '=')) }|" +// TODO ugy kene, h okosan a status utani szamot (barhol lehet!) kiszedni
+ "{ data(fn:substring-after(fn:substring-after($d/child::td[2]/child::a[1]/@href, 'status'), '=')) }|" +// TODO should grab the next number after "status"
"{ data(fn:normalize-space(fn:string-join($d/child::td[3]/text(), ''))) }" +
"</dummy>";
List resultIssueStatus = ScrapingUtils.runXQuery(dom, queryIssueStatus);
@@ -124,7 +124,7 @@
"contains($d/child::td[2]/child::a[1]/@href, 'priority') " +
"return " +
"<dummy>" +
- "{ data(fn:substring(fn:substring-after(fn:substring-after($d/child::td[2]/child::a[1]/@href, 'priority'), '='), 1, 1)) }|" +// TODO DE IGY BE VAN DROTOZVA HOGY A PRIORITY MINDIG 1 KARAKTER!
+ "{ data(fn:substring(fn:substring-after(fn:substring-after($d/child::td[2]/child::a[1]/@href, 'priority'), '='), 1, 1)) }|" +// TODO not appropriate, because priority is hardwired to a single character
"{ data(fn:normalize-space(fn:string-join($d/child::td[3]/text(), ''))) }" +
"</dummy>";
List resultIssuePriority = ScrapingUtils.runXQuery(dom, queryIssuePriority);
@@ -172,7 +172,7 @@
int count = Integer.parseInt(tokenizerIssueStatus.nextToken());
switch(status) {
case 1: openIssues = count; break;
- // TODO 2?
+ // TODO what is 2?
case 3: codingInProgressIssues = count; break;
case 4: reopenedIssues = count; break;
case 5: resolvedIssues = count; break;
@@ -201,14 +201,14 @@
case 3: majorOpenIssues = count; break;
case 4: minorOpenIssues = count; break;
case 5: trivialOpenIssues = count; break;
- // TODO 6?
+ // TODO what is 6?
case 7: optionalOpenIssues = count; break;
default: throw new IllegalArgumentException(String.format("Unknown issue priority: %d", priority));
}
}
// scrape issue assignees
- Map<String, Integer> openIssuesPerAssignee = new HashMap<String, Integer>();//!!! openIssues!
+ Map<String, Integer> openIssuesPerAssignee = new HashMap<String, Integer>();
for(Iterator itIssueAssignee = resultIssueAssignee.iterator(); itIssueAssignee.hasNext();) {
String valueIssueAssignee = ((NodeInfo)itIssueAssignee.next()).getStringValue();
log.debug(String.format("Scraped issue assignee: \"%s\"", valueIssueAssignee));
@@ -219,8 +219,7 @@
openIssuesPerAssignee.put(assignee, count);
}
- //!!! KEPEK GENERALASA -> KIEMEL UJ METODUSBA
- // generate charts
+ // generate issues-per-status chart
Map<Integer, Integer> issuesPerStatus = new HashMap<Integer, Integer>();
if(openIssues > 0)
issuesPerStatus.put(OPEN_COLOR, openIssues);
@@ -237,7 +236,7 @@
ChartUtils.writeChartAsPng(ChartUtils.generateColorCodedPieChart(ChartUtils.mapToPieDataset(issuesPerStatus)), out);
String issuesPerStatusChartUrl = saveCachedFile(encodeCachedFileName(url + "_issues_per_status.png"), new ByteArrayInputStream(out.toByteArray()));
- //!!! MEG EGY KEP
+ // generate issues-per-priority chart
Map<Integer, Integer> openIssuesPerPriority = new HashMap<Integer, Integer>();
if(blockerOpenIssues > 0)
openIssuesPerPriority.put(BLOCKER_COLOR, blockerOpenIssues);
|
