From: <ad...@jb...> - 2005-04-26 17:24:07
|
I'm confused again. We always seem to be on completely different wavelengths :-) 1) I already had a MAP in the original implementation, but changed it to Annotation since we agreed that all config will come from annotations (as opposed to ad hoc invocation payload) and this would make it easier for construct/configure from xml. In fact, there is an open issue on whether the MC should just use AOP's annotation metadata model. There is even a test in the jboss-aspects module using AbstractAnnotationMetaData: http://cvs.sourceforge.net/viewcvs.py/jboss/jboss-aspects/src/tests/org/jboss/test/aspects/microcontainer/test/InterceptorTestCase.java?rev=1.1&view=markup Did you know that about FeatureMetaData or even the tasks I created after our Boston meetings? http://cvs.sourceforge.net/viewcvs.py/jboss/microkernel/src/main/org/jboss/beans/metadata/plugins/AbstractFeatureMetaData.java?r1=1.4&r2=1.5 http://jira.jboss.com/jira/browse/JBMICROCONT-18 2) It is too late to pass this in the join point constructor isn't it? I need to tell JBoss/AOP about the annotations to find out what they mean in terms of dependencies???? This cannot be done at the construction stage, it must be done during DESCRIBE. Otherwise, the MC/AOP integration serves no purpose. | | /** | * Get a constructor join point | * | * @param constructorInfo the constructor info | * @param metadata // THIS IS TOO LATE | * @return the constructor join point | * @throws JoinpointException when no such constructor | */ | ConstructorJoinpoint getConstructorJoinpoint(ConstructorInfo constructorInfo, Map metadata) throws JoinpointException; | Maybe you have simplied this or found a way around the problem? But it seems pretty fundamental to me? 3) The ClassAdapter should just be a bridge to JBoss/AOP or reflection model. That is its only purpose. i.e. which implementation should the MC use. To repeat the only reasons for the reflection model are: a) I need to be convinced that JBoss/AOP (really javassist) can be used in all environments b) AOP's ClassAdapter wasn't finished but I needed to work on other things If (a) can be satisfied, (i.e. in all circumstances no matter what the security/memory restrictions are JBoss/AOP/Javasssit can be used) then I don't have any problem with predecating JBoss/MC on JBoss/AOP and the need for an abstract integration "ClassAdapter" disappears. View the original post : http://www.jboss.org/index.html?module=bb&op=viewtopic&p=3875471#3875471 Reply to the post : http://www.jboss.org/index.html?module=bb&op=posting&mode=reply&p=3875471 |