[jboss-cvs] jboss-portal/wsrp/src/main/org/jboss/portal/wsrp/services ...

[Julien V. <ju...@jb...>]

  User: julien  
  Date: 06/07/10 06:30:25

  Modified:    wsrp/src/main/org/jboss/portal/wsrp/services 
                        AbstractSOAPServiceFactory.java
  Log:
  added comments
  
  Revision  Changes    Path
  1.2       +8 -4      jboss-portal/wsrp/src/main/org/jboss/portal/wsrp/services/AbstractSOAPServiceFactory.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: AbstractSOAPServiceFactory.java
  ===================================================================
  RCS file: /cvsroot/jboss/jboss-portal/wsrp/src/main/org/jboss/portal/wsrp/services/AbstractSOAPServiceFactory.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -b -r1.1 -r1.2
  --- AbstractSOAPServiceFactory.java	10 Jul 2006 10:26:51 -0000	1.1
  +++ AbstractSOAPServiceFactory.java	10 Jul 2006 10:30:25 -0000	1.2
  @@ -28,8 +28,11 @@
   import javax.xml.rpc.Service;
   
   /**
  + * Perform common logic to soap based service factories. This one cache the service
  + * retrieved from the JNDI lookup.
  + *
    * @author <a href="mailto:ju...@jb...">Julien Viet</a>
  - * @version $Revision: 1.1 $
  + * @version $Revision: 1.2 $
    */
   public abstract class AbstractSOAPServiceFactory extends AbstractJNDIServiceFactory
   {
  @@ -54,7 +57,8 @@
      }
   
      /**
  -    * Retrieve the sub from the service
  +    * Retrieve the stub from the service. The stub is not thread safe and must be customized
  +    * for each thead.
       *
       * @param serviceClass the requested service class
       * @param service the service implementation obtained from the JNDI lookup
  @@ -73,7 +77,7 @@
         //
         String key = serviceClass.getName();
   
  -      //
  +      // Get the cached service, it's ok because they are thread safe
         Service service = (Service)services.get(key);
         if (service == null)
         {
  @@ -86,7 +90,8 @@
            }
         }
   
  -      //
  +      // Get the stub from the service, remember that the stub itself is not threasafe
  +      // and must be customized for every request to this method.
         if (service != null)
         {
            return getStubFromService(serviceClass, service);
  @@ -96,5 +101,4 @@
            return null;
         }
      }
  -
   }