[Jboss-dev-forums] [Design of JCA on JBoss] - Re: Quartz, timer unification, message inflow RAR

[<sco...@jb...>]

Some feedback.

1. Is the TimerPropertyKey key needed as a wrapper? Currently it does not even properly wrap its Object key, and even if it did provide an equals/hashCode it would seem to be an unnecessary wrapper around the real key. 

2. Being able to access the TimerData from the Timer interface in the listener callback seems like something we need to support. In the case of both ejb and jmx timers there is a user data notion that can be passed in when the timer is created and retrieved from the timer callback object.

3. What is the usecase for the distinct TimerListener, CancelTimerListener, and StopTimerListener? Wouldn't these be better combined into a single interface with either all three callbacks, or a single callback with a state enum?

4. In terms of the most general timer scheduling method on the TimerManager, the method taking the TimerExcecutionContext would seem to be the place for extended scheduling semantics. Currently it has a period and data notion. I'm thinking we need more of a timer calendar notion to deal with non-trivial timer scheduling ala cron.


View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3953534#3953534

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3953534