[Jboss-dev-forums] [Design of JBossCache] - Re: Reactivating SharedStoreCacheLoader

[<bst...@jb...>]

No, this won't work.  The byte[] returned by _getState() is made up of subsidiary byte[]s for the in-memory state and the persistent state.  The _setState method is responsible for parsing these out and doing the appropriate stuff with each, including passing the *persistent* state to the cache loader.  But CacheLoader.storeEntireState() only knows how to handle the persistent state.

Actually, as I wrote this I realized that for 1.2.4 I did work to make the data format of the in-memory transfer and the persistent transfer consistent.  So *maybe* it will work -- you parse out the the in-memory state and pass it to the cache loader.

This is bad though -- the fact that the data structure of the persistent state and the in-memory state is the same is 1) not part of any interface contract, and therefore 2) if true for the cache loaders we ship with, it's only because *we* wrote them that way.  Other custom implementations may be different.

Re: the timeout and force parameters.  I've no opinion on whether the timeout should be configurable, or whether you should just use StateTransferTimeout.  The combination of "timeout" and "force" was meant to allow the calling code to loop with a successively longer timeout; on the final iteration of the loop, "force" would be set to true, and at that point _getState would force the breakage of any locks in order to ensure the transfer goes through.  Perhaps you should follow a similar approach.

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=3953532#3953532

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=3953532