[Jboss-svn-commits] JBL Code SVN: r4623 - in labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status: plugins plugins/codelines service/impl

[<jbo...@li...>]

Author: wrzep
Date: 2006-06-05 16:45:13 -0400 (Mon, 05 Jun 2006)
New Revision: 4623

Modified:
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/Plugin.java
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesPlugin.java
   labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/impl/ScoresMDB.java
Log:
JBLAB-599
Pawel


Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/Plugin.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/Plugin.java	2006-06-05 19:43:20 UTC (rev 4622)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/Plugin.java	2006-06-05 20:45:13 UTC (rev 4623)
@@ -115,7 +115,7 @@
 			return 0;
 		}
 		
-		float r = (getValue(projectId) / totalScore);
+		float r = ((float) getValue(projectId) / (float) totalScore);
 		
 		return (int) (100.0 * r);
 	}

Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesPlugin.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesPlugin.java	2006-06-05 19:43:20 UTC (rev 4622)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/plugins/codelines/CodeLinesPlugin.java	2006-06-05 20:45:13 UTC (rev 4623)
@@ -47,17 +47,22 @@
 	protected abstract long getValue(String url, String userName, String password); 
 	
 	/** Binds project ids with their values */
-	private Map<String,Long> cashedValues;
+	private Map<String,Long> cachedValues;
 	
 	public CodeLinesPlugin() {
 		super();
-		cashedValues = new HashMap<String,Long>();
+		cachedValues = new HashMap<String,Long>();
 	}
 	
 	@Override
 	public long getValue(String projectId) {
 		
-		if (!cashedValues.containsKey(projectId)) {
+		System.out.print("clp getValue: ");
+		System.out.print(projectId + " ");
+		System.out.println(cachedValues);
+		//TODO and now NPE appears, where exactly??
+		
+		if (!cachedValues.containsKey(projectId)) {
 			
 			long cl = 0;
 			
@@ -70,10 +75,10 @@
 				String password = repo.getPassword();
 				
 				cl = getValue(url, userName, password);
-				cashedValues.put(projectId, new Long(cl));
+				cachedValues.put(projectId, new Long(cl));
 			}
 		}
 		
-		return cashedValues.get(projectId).longValue();
+		return cachedValues.get(projectId).longValue();
 	}
 }

Modified: labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/impl/ScoresMDB.java
===================================================================
--- labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/impl/ScoresMDB.java	2006-06-05 19:43:20 UTC (rev 4622)
+++ labs/jbosslabs/trunk/portal-extensions/forge-status/src/java/org/jboss/forge/status/service/impl/ScoresMDB.java	2006-06-05 20:45:13 UTC (rev 4623)
@@ -65,7 +65,7 @@
 	
 	private static Logger log = Logger.getLogger(ScoresMDB.class);
 	
-	public void onMessage(Message msg) {
+	synchronized public void onMessage(Message msg) {
 		
 		ObjectMessage message = (ObjectMessage) msg;