From: Roy R. <ru...@jb...> - 2006-06-11 21:14:06
|
User: russo Date: 06/06/11 17:14:04 Modified: samples/src/main/org/jboss/samples/portlet/news NewsPortlet.java Log: only use prefs from edit request Revision Changes Path 1.3 +7 -7 jboss-portal/samples/src/main/org/jboss/samples/portlet/news/NewsPortlet.java (In the diff below, changes in quantity of whitespace are not shown.) Index: NewsPortlet.java =================================================================== RCS file: /cvsroot/jboss/jboss-portal/samples/src/main/org/jboss/samples/portlet/news/NewsPortlet.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -b -r1.2 -r1.3 --- NewsPortlet.java 13 Apr 2006 13:46:08 -0000 1.2 +++ NewsPortlet.java 11 Jun 2006 21:14:04 -0000 1.3 @@ -132,13 +132,13 @@ String newURL = null; try { - newURL = request.getParameter("newurl"); +// newURL = request.getParameter("newurl"); response.setContentType("text/html"); - if(null == newURL) - { +// if(null == newURL) +// { newURL = request.getPreferences().getValue("RssXml", RSS_URL); - } +// } xmlInputStream = new URL(newURL).openStream(); if(xmlInputStream == null) @@ -236,10 +236,10 @@ } } - // TODO: error checking for URL + NewZIP + // TODO: error checking for URL //store as the selected xml so that it shows up selected as displays - response.setRenderParameter("newurl", newURL); +// response.setRenderParameter("newurl", newURL); //set the portlet mode back to view response.setPortletMode(PortletMode.VIEW); |
From: Roy R. <ru...@jb...> - 2006-06-11 21:44:50
|
User: russo Date: 06/06/11 17:44:48 Modified: samples/src/main/org/jboss/samples/portlet/news NewsPortlet.java Log: fixed prefs handling Revision Changes Path 1.4 +11 -8 jboss-portal/samples/src/main/org/jboss/samples/portlet/news/NewsPortlet.java (In the diff below, changes in quantity of whitespace are not shown.) Index: NewsPortlet.java =================================================================== RCS file: /cvsroot/jboss/jboss-portal/samples/src/main/org/jboss/samples/portlet/news/NewsPortlet.java,v retrieving revision 1.3 retrieving revision 1.4 diff -u -b -r1.3 -r1.4 --- NewsPortlet.java 11 Jun 2006 21:14:04 -0000 1.3 +++ NewsPortlet.java 11 Jun 2006 21:44:48 -0000 1.4 @@ -132,13 +132,13 @@ String newURL = null; try { -// newURL = request.getParameter("newurl"); + newURL = request.getParameter("newurl"); response.setContentType("text/html"); -// if(null == newURL) -// { + if(null == newURL) + { newURL = request.getPreferences().getValue("RssXml", RSS_URL); -// } + } xmlInputStream = new URL(newURL).openStream(); if(xmlInputStream == null) @@ -227,9 +227,12 @@ PortletPreferences prefs = request.getPreferences(); try { + if(!prefs.isReadOnly("RssXml")) + { prefs.setValue("RssXml", newURL); prefs.store(); } + } catch(Exception e) { e.printStackTrace(); @@ -239,7 +242,7 @@ // TODO: error checking for URL //store as the selected xml so that it shows up selected as displays -// response.setRenderParameter("newurl", newURL); + response.setRenderParameter("newurl", newURL); //set the portlet mode back to view response.setPortletMode(PortletMode.VIEW); |
From: Roy R. <ru...@jb...> - 2006-07-10 18:53:23
|
User: russo Date: 06/07/10 14:53:21 Modified: samples/src/main/org/jboss/samples/portlet/news NewsPortlet.java Log: JBPORTAL-941 - added error handling for no net access. Revision Changes Path 1.5 +4 -4 jboss-portal/samples/src/main/org/jboss/samples/portlet/news/NewsPortlet.java (In the diff below, changes in quantity of whitespace are not shown.) Index: NewsPortlet.java =================================================================== RCS file: /cvsroot/jboss/jboss-portal/samples/src/main/org/jboss/samples/portlet/news/NewsPortlet.java,v retrieving revision 1.4 retrieving revision 1.5 diff -u -b -r1.4 -r1.5 --- NewsPortlet.java 11 Jun 2006 21:44:48 -0000 1.4 +++ NewsPortlet.java 10 Jul 2006 18:53:21 -0000 1.5 @@ -179,8 +179,10 @@ } catch(Exception e) { - log.error("Fatal Error reading/parsing XML Source."); - throw new PortletException(e); + log.error("Fatal Error reading/parsing XML Source.",e); + PrintWriter writer = response.getWriter(); + writer.write("Failed to retrieve News Feed!"); + writer.close(); } finally // close all streams { @@ -239,8 +241,6 @@ } } - // TODO: error checking for URL - //store as the selected xml so that it shows up selected as displays response.setRenderParameter("newurl", newURL); |