From: <ben...@ya...> - 2008-05-21 14:45:56
|
Yep, I concurr! Looks like there's some inconsistency in class tChannelEvent on whether accessors or public members are to be used.. I'd vote accessors myself, as it's easier to add sanity checks, but that's just me... In my working copy, I put the GetChannel() calls into Player.cpp and AlsaPlayer.cpp to get it compiling, but that doesn't treat the more fundamental issue of accessor or public members... Is the jazz++ style to use more public members than accessors? -Ben --- On Wed, 5/21/08, D.B. Moore <db...@ho...> wrote: > From: D.B. Moore <db...@ho...> > Subject: [jazzplusplus-devel] Routine test build results -- Last Changed Rev: 549 > To: jaz...@li... > Date: Wednesday, May 21, 2008, 2:50 AM > Greetings, > > Casually reporting that as of Rev 549 ; > > if g++ -DHAVE_CONFIG_H -I. -I../../jazz/src -I. > -DJAZZ_DATADIR=\"/root/Jazz++/TestInstall/share/Jazz++\" > -Wall -Wno-unknown-pragmas -I../../jazz/Bitmaps > -I/usr/local/wx287/lib/wx/include/gtk2-ansi-release-static-2.8 > -I/usr/local/wx287/include/wx-2.8 -D_FILE_OFFSET_BITS=64 > -D_LARGE_FILES -D__WXGTK__ -g -fno-inline -O0 -MT > AlsaDriver.o -MD -MP -MF ".deps/AlsaDriver.Tpo" > -c -o AlsaDriver.o ../../jazz/src/AlsaDriver.cpp; \ > then mv -f ".deps/AlsaDriver.Tpo" > ".deps/AlsaDriver.Po"; else rm -f > ".deps/AlsaDriver.Tpo"; exit 1; fi > if g++ -DHAVE_CONFIG_H -I. -I../../jazz/src -I. > -DJAZZ_DATADIR=\"/root/Jazz++/TestInstall/share/Jazz++\" > -Wall -Wno-unknown-pragmas -I../../jazz/Bitmaps > -I/usr/local/wx287/lib/wx/include/gtk2-ansi-release-static-2.8 > -I/usr/local/wx287/include/wx-2.8 -D_FILE_OFFSET_BITS=64 > -D_LARGE_FILES -D__WXGTK__ -g -fno-inline -O0 -MT > AlsaPlayer.o -MD -MP -MF ".deps/AlsaPlayer.Tpo" > -c -o AlsaPlayer.o ../../jazz/src/AlsaPlayer.cpp; \ > then mv -f ".deps/AlsaPlayer.Tpo" > ".deps/AlsaPlayer.Po"; else rm -f > ".deps/AlsaPlayer.Tpo"; exit 1; fi > ./../jazz/src/AlsaPlayer.cpp: In member function 'int > tAlsaPlayer::OutEvent(JZEvent*, int)': > ./../jazz/src/AlsaPlayer.cpp:416: error: 'class > tKeyOn' has no member named 'Channel' > ./../jazz/src/AlsaPlayer.cpp:427: error: 'class > tKeyOff' has no member named 'Channel' > ./../jazz/src/AlsaPlayer.cpp:438: error: 'class > tProgram' has no member named 'Channel' > ./../jazz/src/AlsaPlayer.cpp:448: error: 'class > tKeyPressure' has no member named 'Channel' > ./../jazz/src/AlsaPlayer.cpp:459: error: 'class > tChnPressure' has no member named 'Channel' > ./../jazz/src/AlsaPlayer.cpp:469: error: 'class > tControl' has no member named 'Channel' > ./../jazz/src/AlsaPlayer.cpp:480: error: 'class > tPitch' has no member named 'Channel' > make[2]: *** [AlsaPlayer.o] Error 1 > make[2]: Leaving directory > `/mnt/store/jazzplusplus/trunk/Build/src' > make[1]: *** [all] Error 2 > make[1]: Leaving directory > `/mnt/store/jazzplusplus/trunk/Build/src' > make: *** [all-recursive] Error 1 > > > Regards, > > Donald B > _________________________________________________________________ > Are you paid what you're worth? Find out: SEEK Salary > Centre > http://a.ninemsn.com.au/b.aspx?URL=http%3A%2F%2Fninemsn%2Eseek%2Ecom%2Eau%2Fcareer%2Dresources%2Fsalary%2Dcentre%2F%3Ftracking%3Dsk%3Ahet%3Asc%3Anine%3A0%3Ahot%3Atext&_t=764565661&_r=OCT07_endtext_salary&_m=EXT > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > jazzplusplus-devel mailing list > jaz...@li... > https://lists.sourceforge.net/lists/listinfo/jazzplusplus-devel |