jazzlib-developers

[Jazzlib-developers] jazzlib bug fixes

[<joe...@gm...>]

Hi!

OK it's me again. Please apologize but my fix for ZipFile.java was not 
correct!

It fails with the trivial case, an empty zip file. Empty zip files are rare 
and useless, of course, but an EOFException in that case is really not 
required at all. Attached you find a correct ZipFIle.java that works now.

Another issue was that DeflaterEngine does not correctly deflate multiple zip 
entries. It fails at a subsequent zip entry to deflate with an 
ArrayIndexOutOfBoundException. I guess this has been reported as a bug. I 
fixed this, too. You find a modified DeflaterEngine.java attached. The 
reset() method has been extended by two more lines to reset some fields.

With jazzlib status now, I can now add and remove zip entries within an 
archive from a Swing tool. That's cool! Once again thanks for the library. If 
there are more jazzlib issues, I'll be back.

Cheers, Jörg

Re: [Jazzlib-developers] jazzlib bug fixes

[Jochen H. <Joc...@In...>]

On Oct 9, Jörg Prante wrote:
> Hi!
> OK it's me again. Please apologize but my fix for ZipFile.java was not 
> correct!
>
> It fails with the trivial case, an empty zip file. Empty zip files are rare 
> and useless, of course, but an EOFException in that case is really not 
> required at all. Attached you find a correct ZipFIle.java that works now.

I have committed a similar fix to the classpath repository.  Note that
this now contains the official code.

> Another issue was that DeflaterEngine does not correctly deflate multiple zip 
> entries. It fails at a subsequent zip entry to deflate with an 
> ArrayIndexOutOfBoundException. I guess this has been reported as a bug. I 
> fixed this, too. You find a modified DeflaterEngine.java attached. The 
> reset() method has been extended by two more lines to reset some fields.

That bug was already fixed in the classpath repository.  There was
another bug that could cause a ArrayIndexOutOfBoundException, which
was fixed there, too.

BTW, we should make a script that copies the classpath java.util.zip
sources into a net.sf.jazzlib package which can then be used for
inclusion in applet code.  This package could be distributed from the
SourceForge site.  John what do you think?

  Jochen

Re: [Jazzlib-developers] jazzlib bug fixes

[John L. <je...@pi...>]

> That bug was already fixed in the classpath repository.  There was
> another bug that could cause a ArrayIndexOutOfBoundException, which
> was fixed there, too.
> 
> BTW, we should make a script that copies the classpath java.util.zip
> sources into a net.sf.jazzlib package which can then be used for
> inclusion in applet code.  This package could be distributed from the
> SourceForge site.  John what do you think?

Sounds like a good idea. I'll take responsibility for this (unless you want to do it).

This means changing all the headers in the source files to indicate a new package.

I noticed today that the jikes research VM people (used to be called Jalapeno) have used Jazzlib (at one time or another).

http://www-124.ibm.com/developerworks/oss/jikesrvm/index.shtml

I'll start working on the new package, I'll post to the list and update the web site when I'm done.

John Leuner

Re: [Jazzlib-developers] jazzlib bug fixes

[John L. <je...@pi...>]

> BTW, we should make a script that copies the classpath java.util.zip
> sources into a net.sf.jazzlib package which can then be used for
> inclusion in applet code.  This package could be distributed from the
> SourceForge site.  John what do you think?

I have updated the sf site with release 0.03. 

I have not tested it, but it should work.

Where should I put the script?

Should I put it in the java.util.zip directory in Classpath (that's where I run it from, do you think they'll mind if there's a script there in CVS?).

John Leuner

Re: [Jazzlib-developers] jazzlib bug fixes

[Jochen H. <Joc...@In...>]

On Oct 20, John Leuner wrote:
> > BTW, we should make a script that copies the classpath java.util.zip
> > sources into a net.sf.jazzlib package which can then be used for
> > inclusion in applet code.  This package could be distributed from the
> > SourceForge site.  John what do you think?
> 
> I have updated the sf site with release 0.03. 
> 
> I have not tested it, but it should work.
> 
> Where should I put the script?
> 
> Should I put it in the java.util.zip directory in Classpath (that's
> where I run it from, do you think they'll mind if there's a script
> there in CVS?).

There is also a classpath/script directory.  And the
mkcollections.pl.in script (that does a very similar thing) was placed
in classpath/lib.

  Jochen