|
From: Berni <be...@kn...> - 2002-01-24 09:26:38
|
Quoting Berni... > 1. Is there any reason why you set all the login data attributes in class > Status from private to protected? > > 2. Don't write buggy constructors. I like proper classes. Either initialize > ALL attributes or leave away the constructor. > > 3. Why the hell do we need set... () methods for login data attributes? > > 4. Usually I know what I'm doing (yes, I do!), at last better than you do. > Please ask me before you hack my code and threw over every single > paradigm I believe in. > > thanks. berni Now, little bit more constructive: Preferences is created as soon as the application gets started. Status on the other hand is always created for a login session. This is something different, because it should be possible to use jayshare even when you are offline (to set up the export list or to modify the download queue, both needs presence of the preferences, but not of status). That means: Preferences could use Status, but does not derive from it. It could send login data to the Status instance as soon as it is to be created. Another major difference: Preferences has to be persistent, Status is transient. I don't think it is a good idea to derive a persistent from a transient class, however, I'd love to get your arguments ... cu (i hope today), berni |