Menu

#3 Delta implementation normalization

open
nobody
None
5
2009-07-13
2009-07-13
No

I noted that the text delta implementation was basically just a copy of the binary one, using CharBuffer instead of ByteBuffer.
I've introduced an abstraction over the buffer type to allow using a single implementation for both text and binary.

Discussion

  • Alessandro Nistico

    Code normalization patch

     
  • Elias Ross

    Elias Ross - 2009-09-24

    Thanks for your contribution. I'll check out the patch.

     
  • Elias Ross

    Elias Ross - 2009-09-24

    Since the patch isn't working cleanly, could you send me the actual files you have? Thanks!

     
  • Alessandro Nistico

    Full modified source tree

     
  • Alessandro Nistico

    I've attached the source files as requested. Sorry the patch did not work.
    This source tree modifies also the Checksum class that becomes itself an hash map that uses primitive longs as key and allow to remove any dependency from the GNU Trove framework.
    I extensively use findbugs annotations so you'll find that the code is pretty full with them,

     

Log in to post a comment.