Re: [Javaxdelta-devel] Can I help? SVN migration; Maven build; GDiff enhancements

[Elias R. <ge...@no...>]

On Wed, Jun 4, 2008 at 3:58 AM, Torgeir Veimo <to...@po...> wrote:
>
> I was waiting for sourceforge to do the conversion. I didn't have the time
> to hassle them to get it done though. I guess it could be done manually by
> cvs2svn and svnadmin as well.

I've done the manual conversion before. I don't think Sourceforge does
anything for you anymore.

I'd be happy to do it for you.

>> Secondly, I'd also like to fix up the repository layout to be more
>> "Maven-like". For editing, Eclipse doesn't like your directory
>> structure, so it would seem wise to update it to be more
>> Eclipse-friendly. I would like to keep the build.xml and create a
>> Maven pom.xml as well for build integration as well.
>
>> Thirdly, I'd like to clean up the code. I do see a bunch of unused
>> variables and junk floating around etc., though keep the public
>> interface intact and compiling on JDK 1.3. There's also a number of
>> potential issues where the return value from "read(byte b[] ...)"
>> calls aren't checked.
>
>> And lastly, something I'd like to add for dealing with text strings is
>> a character-based encoding for GDIFF. This is so that changes can be
>> stored in a VARCHAR or CLOB type column. I would basically create a
>> sub-package called "com.nothome.delta.char" which could use character
>> streams.
>
>
> All of this sounds interesting. Can you provide a patch with your
> improvements? Once you've posted some code I can grant you committer access.

I created a patch for the text "diff". Look under "Tracker - Patches".
There's a number of tests for the different files. The package is
"text" since "char" is a Java reserved word.

I left off the code clean-up changes since I'd like to fix the
automated tests before I potentially break things. It seems there's
some files it needs that are missing.

I also can't create a pom.xml until I can move the main source files
out of the project root directory.