Hi! I'm trying to use this library on Internet Explorer 7, and I have found many incompatibilities in the code (commas on the last element of an object, apis on some DOM Element Objects…).
I'm in the process to fix that, is it possible to send you patches?
Reading the code I have one question, why you don't use some kind of js abstraction library, like jquery? It is necesary for flot plotting anyway….
Thanks!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
As for the coding style:
you are right… it could have been done better.
At this point in time, though, I am not really in the mood for refactoring.
Unless it simplifies the code drastically.
Thanks,
Igor
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2013-04-15
Hi, Igor.
I will send you the patch when I finish testing it on IE. Do you mind if I start to use jquery on some sections of code? It simplifies the code too much, especially with some "peculiarities" of IE javascript interpreter.
Regards.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi! I'm trying to use this library on Internet Explorer 7, and I have found many incompatibilities in the code (commas on the last element of an object, apis on some DOM Element Objects…).
I'm in the process to fix that, is it possible to send you patches?
Reading the code I have one question, why you don't use some kind of js abstraction library, like jquery? It is necesary for flot plotting anyway….
Thanks!
Hi Felix.
Patches would be most welcome.
As for the coding style:
you are right… it could have been done better.
At this point in time, though, I am not really in the mood for refactoring.
Unless it simplifies the code drastically.
Thanks,
Igor
Hi, Igor.
I will send you the patch when I finish testing it on IE. Do you mind if I start to use jquery on some sections of code? It simplifies the code too much, especially with some "peculiarities" of IE javascript interpreter.
Regards.
Feel free to use the best possible code practices when writing now code ;)
(as long as it works with existing Web pages)
Thanks,
Igor